media: cedrus: Add missing v4l2_ctrl_request_hdl_put() (b3006397) · Commits · 戴 / test

The check for a required control in the request was missing a call to v4l2_ctrl_request_hdl_put() in the error path. Fix it. Fixes: ("media: platform: Add Cedrus VPU decoder driver") Signed-off-by:

Ezequiel Garcia <ezequiel@collabora.com> Signed-off-by:

Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

drivers/staging/media/sunxi/cedrus/cedrus.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -199,6 +199,7 @@ static int cedrus_request_validate(struct media_request *req)
		struct v4l2_ctrl *ctrl_test;
		unsigned int count;
		unsigned int i;
		int ret = 0;

		list_for_each_entry(obj, &req->objects, list) {
		struct vb2_buffer *vb;
		@@ -243,12 +244,16 @@ static int cedrus_request_validate(struct media_request *req)
		if (!ctrl_test) {
		v4l2_info(&ctx->dev->v4l2_dev,
		"Missing required codec control\n");
		return -ENOENT;
		ret = -ENOENT;
		break;
		}
		}

		v4l2_ctrl_request_hdl_put(hdl);

		if (ret)
		return ret;

		return vb2_request_validate(req);
		}

Admin message