Commit 2e7c8fb8 authored Aug 12, 2020 by Hans Verkuil Committed by Mauro Carvalho Chehab Aug 27, 2020

media: vicodec: add missing v4l2_ctrl_request_hdl_put()



The check for a required control in the request was missing a call to
v4l2_ctrl_request_hdl_put(), so the control request object was never
released.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 997deb81 ("media: vicodec: Add support for stateless decoder.")
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 4ffb879e

drivers/media/test-drivers/vicodec/vicodec-core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1994,6 +1994,7 @@ static int vicodec_request_validate(struct media_request *req)
		}
		ctrl = v4l2_ctrl_request_hdl_ctrl_find(hdl,
		vicodec_ctrl_stateless_state.id);
		v4l2_ctrl_request_hdl_put(hdl);
		if (!ctrl) {
		v4l2_info(&ctx->dev->v4l2_dev,
		"Missing required codec control\n");

Admin message