Unverified Commit af62a3c8 authored Jul 10, 2019 by Hariprasad Kelam Committed by Mark Brown Jul 22, 2019

ASoC: wcd9335: add irqflag IRQF_ONESHOT flag



Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".

fixes below issue reported by coccicheck

sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Link: https://lore.kernel.org/r/20190710021627.GA13396@hari-Inspiron-1545


Signed-off-by: Mark Brown <broonie@kernel.org>

parent e1fb714b

sound/soc/codecs/wcd9335.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4062,7 +4062,8 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)

		ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
		wcd9335_irqs[i].handler,
		IRQF_TRIGGER_RISING,
		IRQF_TRIGGER_RISING \|
		IRQF_ONESHOT,
		wcd9335_irqs[i].name, wcd);
		if (ret) {
		dev_err(wcd->dev, "Failed to request %s\n",

Admin message