Unverified Commit e1fb714b authored by Hariprasad Kelam's avatar Hariprasad Kelam Committed by Mark Brown
Browse files

ASoC: bcm: cygnus-pcm: Unneeded variable: "ret". 



This patch fixes below issues reported by coccicheck

sound/soc/bcm/cygnus-pcm.c:642:5-8: Unneeded variable: "ret". Return "0"
on line 650
sound/soc/bcm/cygnus-pcm.c:671:5-8: Unneeded variable: "ret". Return "0"
on line 696

We cannot change return type of these functions as they are callback
functions of snd_pcm_ops

Signed-off-by: default avatarHariprasad Kelam <hariprasad.kelam@gmail.com>
Link: https://lore.kernel.org/r/20190709184236.GA7873@hari-Inspiron-1545


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1d3dd532

sound/soc/bcm/cygnus-pcm.c

+2 −4
Original line number Diff line number Diff line
@@ -639,7 +639,6 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream, 
	struct snd_soc_pcm_runtime *rtd = substream->private_data;

	struct snd_pcm_runtime *runtime = substream->runtime;

	struct cygnus_aio_port *aio;

	int ret = 0;



	aio = cygnus_dai_get_dma_data(substream);

	dev_dbg(rtd->cpu_dai->dev, "%s  port %d\n", __func__, aio->portnum);
@@ -647,7 +646,7 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream, 
	snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer);

	runtime->dma_bytes = params_buffer_bytes(params);



	return ret;

	return 0;

}



static int cygnus_pcm_hw_free(struct snd_pcm_substream *substream)
@@ -668,7 +667,6 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream) 
	struct snd_pcm_runtime *runtime = substream->runtime;

	struct cygnus_aio_port *aio;

	unsigned long bufsize, periodsize;

	int ret = 0;

	bool is_play;

	u32 start;

	struct ringbuf_regs *p_rbuf = NULL;
@@ -693,7 +691,7 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream) 
	ringbuf_set_initial(aio->cygaud->audio, p_rbuf, is_play, start,

				periodsize, bufsize);



	return ret;

	return 0;

}



static snd_pcm_uframes_t cygnus_pcm_pointer(struct snd_pcm_substream *substream)

CRA Git | Maintained and supported by SUSTech CRA and CCSE