Commit af133e86 authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers
Browse files

xfs: verify inode buffers as they are read from disk 



Add an inode buffer verify callback function and pass it into the
buffer read functions. Inodes are special in that the verbose checks
will be done when reading the inode, but we still need to sanity
check the buffer when that is first read. Always verify the magic
numbers in all inodes in the buffer, rather than jus ton debug
kernels.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarPhil White <pwhite@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent bb80c6d7

fs/xfs/xfs_inode.c

+51 −49
Original line number Diff line number Diff line
@@ -382,6 +382,46 @@ xfs_inobp_check( 
}

#endif



static void

xfs_inode_buf_verify(

	struct xfs_buf	*bp)

{

	struct xfs_mount *mp = bp->b_target->bt_mount;

	int		i;

	int		ni;



	/*

	 * Validate the magic number and version of every inode in the buffer

	 */

	ni = XFS_BB_TO_FSB(mp, bp->b_length) * mp->m_sb.sb_inopblock;

	for (i = 0; i < ni; i++) {

		int		di_ok;

		xfs_dinode_t	*dip;



		dip = (struct xfs_dinode *)xfs_buf_offset(bp,

					(i << mp->m_sb.sb_inodelog));

		di_ok = dip->di_magic == cpu_to_be16(XFS_DINODE_MAGIC) &&

			    XFS_DINODE_GOOD_VERSION(dip->di_version);

		if (unlikely(XFS_TEST_ERROR(!di_ok, mp,

						XFS_ERRTAG_ITOBP_INOTOBP,

						XFS_RANDOM_ITOBP_INOTOBP))) {

			xfs_buf_ioerror(bp, EFSCORRUPTED);

			XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,

					     mp, dip);

#ifdef DEBUG

			xfs_emerg(mp,

				"bad inode magic/vsn daddr %lld #%d (magic=%x)",

				(unsigned long long)bp->b_bn, i,

				be16_to_cpu(dip->di_magic));

			ASSERT(0);

#endif

		}

	}

	xfs_inobp_check(mp, bp);

	bp->b_iodone = NULL;

	xfs_buf_ioend(bp, 0);

}



/*

 * This routine is called to map an inode to the buffer containing the on-disk

 * version of the inode.  It returns a pointer to the buffer containing the
@@ -403,63 +443,25 @@ xfs_imap_to_bp( 
{

	struct xfs_buf		*bp;

	int			error;

	int			i;

	int			ni;



	buf_flags |= XBF_UNMAPPED;

	error = xfs_trans_read_buf(mp, tp, mp->m_ddev_targp, imap->im_blkno,

				   (int)imap->im_len, buf_flags, &bp, NULL);

				   (int)imap->im_len, buf_flags, &bp,

				   xfs_inode_buf_verify);

	if (error) {

		if (error != EAGAIN) {

			xfs_warn(mp,

				"%s: xfs_trans_read_buf() returned error %d.",

				__func__, error);

		} else {

		if (error == EAGAIN) {

			ASSERT(buf_flags & XBF_TRYLOCK);

		}

			return error;

		}



	/*

	 * Validate the magic number and version of every inode in the buffer

	 * (if DEBUG kernel) or the first inode in the buffer, otherwise.

	 */

#ifdef DEBUG

	ni = BBTOB(imap->im_len) >> mp->m_sb.sb_inodelog;

#else	/* usual case */

	ni = 1;

#endif



	for (i = 0; i < ni; i++) {

		int		di_ok;

		xfs_dinode_t	*dip;



		dip = (xfs_dinode_t *)xfs_buf_offset(bp,

					(i << mp->m_sb.sb_inodelog));

		di_ok = dip->di_magic == cpu_to_be16(XFS_DINODE_MAGIC) &&

			    XFS_DINODE_GOOD_VERSION(dip->di_version);

		if (unlikely(XFS_TEST_ERROR(!di_ok, mp,

						XFS_ERRTAG_ITOBP_INOTOBP,

						XFS_RANDOM_ITOBP_INOTOBP))) {

			if (iget_flags & XFS_IGET_UNTRUSTED) {

				xfs_trans_brelse(tp, bp);

		if (error == EFSCORRUPTED &&

		    (iget_flags & XFS_IGET_UNTRUSTED))

			return XFS_ERROR(EINVAL);

			}

			XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,

					     mp, dip);

#ifdef DEBUG

			xfs_emerg(mp,

				"bad inode magic/vsn daddr %lld #%d (magic=%x)",

				(unsigned long long)imap->im_blkno, i,

				be16_to_cpu(dip->di_magic));

			ASSERT(0);

#endif

			xfs_trans_brelse(tp, bp);

			return XFS_ERROR(EFSCORRUPTED);

		}

	}



	xfs_inobp_check(mp, bp);

		xfs_warn(mp, "%s: xfs_trans_read_buf() returned error %d.",

			__func__, error);

		return error;

	}



	*bpp = bp;

	*dipp = (struct xfs_dinode *)xfs_buf_offset(bp, imap->im_boffset);

CRA Git | Maintained and supported by SUSTech CRA and CCSE