Commit bb80c6d7 authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers
Browse files

xfs: verify AGFL blocks as they are read from disk 



Add an AGFL block verify callback function and pass it into the
buffer read functions.

While this commit adds verification code to the AGFL, it cannot be
used reliably until the CRC format change comes along as mkfs does
not initialise the full AGFL. Hence it can be full of garbage at the
first mount and will fail verification right now. CRC enabled
filesystems won't have this problem, so leave the code that has
already been written ifdef'd out until the proper time.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarPhil White <pwhite@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent 3702ce6e

fs/xfs/xfs_alloc.c

+38 −1
Original line number Diff line number Diff line
@@ -430,6 +430,43 @@ xfs_alloc_fixup_trees( 
	return 0;

}



void

xfs_agfl_read_verify(

	struct xfs_buf	*bp)

{

#ifdef WHEN_CRCS_COME_ALONG

	/*

	 * we cannot actually do any verification of the AGFL because mkfs does

	 * not initialise the AGFL to zero or NULL. Hence the only valid part of

	 * the AGFL is what the AGF says is active. We can't get to the AGF, so

	 * we can't verify just those entries are valid.

	 *

	 * This problem goes away when the CRC format change comes along as that

	 * requires the AGFL to be initialised by mkfs. At that point, we can

	 * verify the blocks in the agfl -active or not- lie within the bounds

	 * of the AG. Until then, just leave this check ifdef'd out.

	 */

	struct xfs_mount *mp = bp->b_target->bt_mount;

	struct xfs_agfl	*agfl = XFS_BUF_TO_AGFL(bp);

	int		agfl_ok = 1;



	int		i;



	for (i = 0; i < XFS_AGFL_SIZE(mp); i++) {

		if (be32_to_cpu(agfl->agfl_bno[i]) == NULLAGBLOCK ||

		    be32_to_cpu(agfl->agfl_bno[i]) >= mp->m_sb.sb_agblocks)

			agfl_ok = 0;

	}



	if (!agfl_ok) {

		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, agfl);

		xfs_buf_ioerror(bp, EFSCORRUPTED);

	}

#endif

	bp->b_iodone = NULL;

	xfs_buf_ioend(bp, 0);

}



/*

 * Read in the allocation group free block array.

 */
@@ -447,7 +484,7 @@ xfs_alloc_read_agfl( 
	error = xfs_trans_read_buf(

			mp, tp, mp->m_ddev_targp,

			XFS_AG_DADDR(mp, agno, XFS_AGFL_DADDR(mp)),

			XFS_FSS_TO_BB(mp, 1), 0, &bp, NULL);

			XFS_FSS_TO_BB(mp, 1), 0, &bp, xfs_agfl_read_verify);

	if (error)

		return error;

	ASSERT(!xfs_buf_geterror(bp));

CRA Git | Maintained and supported by SUSTech CRA and CCSE