Commit ad0593ec authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/qedr: Remove unsupported modify_port callback 

There is no need to return always zero for function which is not
supported.

Fixes: ac1b36e5 ("qedr: Add support for user context verbs")
Link: https://lore.kernel.org/r/20191028155931.1114-5-kamalheib1@gmail.com


Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 6135b711

drivers/infiniband/hw/qedr/main.c

+0 −1
Original line number Diff line number Diff line
@@ -213,7 +213,6 @@ static const struct ib_device_ops qedr_dev_ops = { 
	.map_mr_sg = qedr_map_mr_sg,

	.mmap = qedr_mmap,

	.mmap_free = qedr_mmap_free,

	.modify_port = qedr_modify_port,

	.modify_qp = qedr_modify_qp,

	.modify_srq = qedr_modify_srq,

	.poll_cq = qedr_poll_cq,

drivers/infiniband/hw/qedr/verbs.c

+0 −6
Original line number Diff line number Diff line
@@ -256,12 +256,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) 
	return 0;

}



int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask,

		     struct ib_port_modify *props)

{

	return 0;

}



int qedr_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata)

{

	struct ib_device *ibdev = uctx->device;

drivers/infiniband/hw/qedr/verbs.h

+0 −2
Original line number Diff line number Diff line
@@ -35,8 +35,6 @@ 
int qedr_query_device(struct ib_device *ibdev,

		      struct ib_device_attr *attr, struct ib_udata *udata);

int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props);

int qedr_modify_port(struct ib_device *, u8 port, int mask,

		     struct ib_port_modify *props);



int qedr_iw_query_gid(struct ib_device *ibdev, u8 port,

		      int index, union ib_gid *gid);

CRA Git | Maintained and supported by SUSTech CRA and CCSE