Commit 6135b711 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/ocrdma: Remove unsupported modify_port callback 

There is no need to return always zero for function which is not
supported.

Fixes: fe2caefc ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
Link: https://lore.kernel.org/r/20191028155931.1114-4-kamalheib1@gmail.com


Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 25f3b49b

drivers/infiniband/hw/ocrdma/ocrdma_main.c

+0 −1
Original line number Diff line number Diff line
@@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = { 
	.get_port_immutable = ocrdma_port_immutable,

	.map_mr_sg = ocrdma_map_mr_sg,

	.mmap = ocrdma_mmap,

	.modify_port = ocrdma_modify_port,

	.modify_qp = ocrdma_modify_qp,

	.poll_cq = ocrdma_poll_cq,

	.post_recv = ocrdma_post_recv,

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

+0 −6
Original line number Diff line number Diff line
@@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev, 
	return 0;

}



int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask,

		       struct ib_port_modify *props)

{

	return 0;

}



static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr,

			   unsigned long len)

{

drivers/infiniband/hw/ocrdma/ocrdma_verbs.h

+0 −2
Original line number Diff line number Diff line
@@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); 
int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props,

			struct ib_udata *uhw);

int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props);

int ocrdma_modify_port(struct ib_device *, u8 port, int mask,

		       struct ib_port_modify *props);



enum rdma_protocol_type

ocrdma_query_protocol(struct ib_device *device, u8 port_num);

CRA Git | Maintained and supported by SUSTech CRA and CCSE