Commit ac031589 authored by Rik van Riel's avatar Rik van Riel Committed by Ingo Molnar
Browse files

x86/mm/tlb: Make lazy TLB mode lazier 



Lazy TLB mode can result in an idle CPU being woken up by a TLB flush,
when all it really needs to do is reload %CR3 at the next context switch,
assuming no page table pages got freed.

Memory ordering is used to prevent race conditions between switch_mm_irqs_off,
which checks whether .tlb_gen changed, and the TLB invalidation code, which
increments .tlb_gen whenever page table entries get invalidated.

The atomic increment in inc_mm_tlb_gen is its own barrier; the context
switch code adds an explicit barrier between reading tlbstate.is_lazy and
next->context.tlb_gen.

Unlike the 2016 version of this patch, CPUs with cpu_tlbstate.is_lazy set
are not removed from the mm_cpumask(mm), since that would prevent the TLB
flush IPIs at page table free time from being sent to all the CPUs
that need them.

This patch reduces total CPU use in the system by about 1-2% for a
memcache workload on two socket systems, and by about 1% for a heavily
multi-process netperf between two systems.

Tested-by: default avatarSong Liu <songliubraving@fb.com>
Signed-off-by: default avatarRik van Riel <riel@surriel.com>
Acked-by: default avatarDave Hansen <dave.hansen@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: efault@gmx.de
Cc: kernel-team@fb.com
Cc: luto@kernel.org
Link: http://lkml.kernel.org/r/20180716190337.26133-5-riel@surriel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 61d0beb5

arch/x86/mm/tlb.c

+59 −9
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
#include <linux/export.h>

#include <linux/cpu.h>

#include <linux/debugfs.h>

#include <linux/gfp.h>



#include <asm/tlbflush.h>

#include <asm/mmu_context.h>
@@ -185,6 +186,7 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, 
{

	struct mm_struct *real_prev = this_cpu_read(cpu_tlbstate.loaded_mm);

	u16 prev_asid = this_cpu_read(cpu_tlbstate.loaded_mm_asid);

	bool was_lazy = this_cpu_read(cpu_tlbstate.is_lazy);

	unsigned cpu = smp_processor_id();

	u64 next_tlb_gen;

	bool need_flush;
@@ -242,17 +244,40 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, 
			   next->context.ctx_id);



		/*

		 * We don't currently support having a real mm loaded without

		 * our cpu set in mm_cpumask().  We have all the bookkeeping

		 * in place to figure out whether we would need to flush

		 * if our cpu were cleared in mm_cpumask(), but we don't

		 * currently use it.

		 * Even in lazy TLB mode, the CPU should stay set in the

		 * mm_cpumask. The TLB shootdown code can figure out from

		 * from cpu_tlbstate.is_lazy whether or not to send an IPI.

		 */

		if (WARN_ON_ONCE(real_prev != &init_mm &&

				 !cpumask_test_cpu(cpu, mm_cpumask(next))))

			cpumask_set_cpu(cpu, mm_cpumask(next));



		/*

		 * If the CPU is not in lazy TLB mode, we are just switching

		 * from one thread in a process to another thread in the same

		 * process. No TLB flush required.

		 */

		if (!was_lazy)

			return;



		/*

		 * Read the tlb_gen to check whether a flush is needed.

		 * If the TLB is up to date, just use it.

		 * The barrier synchronizes with the tlb_gen increment in

		 * the TLB shootdown code.

		 */

		smp_mb();

		next_tlb_gen = atomic64_read(&next->context.tlb_gen);

		if (this_cpu_read(cpu_tlbstate.ctxs[prev_asid].tlb_gen) ==

				next_tlb_gen)

			return;



		/*

		 * TLB contents went out of date while we were in lazy

		 * mode. Fall through to the TLB switching code below.

		 */

		new_asid = prev_asid;

		need_flush = true;

	} else {

		u64 last_ctx_id = this_cpu_read(cpu_tlbstate.last_ctx_id);
@@ -454,6 +479,9 @@ static void flush_tlb_func_common(const struct flush_tlb_info *f, 
		 * paging-structure cache to avoid speculatively reading

		 * garbage into our TLB.  Since switching to init_mm is barely

		 * slower than a minimal flush, just switch to init_mm.

		 *

		 * This should be rare, with native_flush_tlb_others skipping

		 * IPIs to lazy TLB mode CPUs.

		 */

		switch_mm_irqs_off(NULL, &init_mm, NULL);

		return;
@@ -560,6 +588,9 @@ static void flush_tlb_func_remote(void *info) 
void native_flush_tlb_others(const struct cpumask *cpumask,

			     const struct flush_tlb_info *info)

{

	cpumask_var_t lazymask;

	unsigned int cpu;



	count_vm_tlb_event(NR_TLB_REMOTE_FLUSH);

	if (info->end == TLB_FLUSH_ALL)

		trace_tlb_flush(TLB_REMOTE_SEND_IPI, TLB_FLUSH_ALL);
@@ -583,8 +614,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask, 
		 * that UV should be updated so that smp_call_function_many(),

		 * etc, are optimal on UV.

		 */

		unsigned int cpu;



		cpu = smp_processor_id();

		cpumask = uv_flush_tlb_others(cpumask, info);

		if (cpumask)
@@ -592,8 +621,29 @@ void native_flush_tlb_others(const struct cpumask *cpumask, 
					       (void *)info, 1);

		return;

	}



	/*

	 * A temporary cpumask is used in order to skip sending IPIs

	 * to CPUs in lazy TLB state, while keeping them in mm_cpumask(mm).

	 * If the allocation fails, simply IPI every CPU in mm_cpumask.

	 */

	if (!alloc_cpumask_var(&lazymask, GFP_ATOMIC)) {

		smp_call_function_many(cpumask, flush_tlb_func_remote,

			       (void *)info, 1);

		return;

	}



	cpumask_copy(lazymask, cpumask);



	for_each_cpu(cpu, lazymask) {

		if (per_cpu(cpu_tlbstate.is_lazy, cpu))

			cpumask_clear_cpu(cpu, lazymask);

	}



	smp_call_function_many(lazymask, flush_tlb_func_remote,

			       (void *)info, 1);



	free_cpumask_var(lazymask);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE