Commit aaeb1dea authored Feb 15, 2019 by Ivan Vecera Committed by David S. Miller Feb 17, 2019

net: sched: sch_api: set an error msg when qdisc_alloc_handle() fails



This patch sets an error message in extack when the number of qdisc
handles exceeds the maximum. Also the error-code ENOSPC is more
appropriate than ENOMEM in this situation.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reported-by: Li Shuang <shuali@redhat.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 56425638

net/sched/sch_api.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1201,10 +1201,12 @@ static struct Qdisc qdisc_create(struct net_device dev,
		} else {
		if (handle == 0) {
		handle = qdisc_alloc_handle(dev);
		err = -ENOMEM;
		if (handle == 0)
		if (handle == 0) {
		NL_SET_ERR_MSG(extack, "Maximum number of qdisc handles was exceeded");
		err = -ENOSPC;
		goto err_out3;
		}
		}
		if (!netif_is_multiqueue(dev))
		sch->flags \|= TCQ_F_ONETXQUEUE;
		}

Admin message