Commit aad4e530 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: imx27: Simplify helper function to enable and disable clocks 



pwm_imx27_clk_prepare_enable() took a pointer to a struct pwm_chip just
to convert it to a struct pwm_imx27_chip pointer while all callers
already have the latter. Ditto for pwm_imx27_clk_disable_unprepare().

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 15d4dbd6

drivers/pwm/pwm-imx27.c

+7 −10
Original line number Diff line number Diff line
@@ -96,9 +96,8 @@ struct pwm_imx27_chip { 


#define to_pwm_imx27_chip(chip)	container_of(chip, struct pwm_imx27_chip, chip)



static int pwm_imx27_clk_prepare_enable(struct pwm_chip *chip)

static int pwm_imx27_clk_prepare_enable(struct pwm_imx27_chip *imx)

{

	struct pwm_imx27_chip *imx = to_pwm_imx27_chip(chip);

	int ret;



	ret = clk_prepare_enable(imx->clk_ipg);
@@ -114,10 +113,8 @@ static int pwm_imx27_clk_prepare_enable(struct pwm_chip *chip) 
	return 0;

}



static void pwm_imx27_clk_disable_unprepare(struct pwm_chip *chip)

static void pwm_imx27_clk_disable_unprepare(struct pwm_imx27_chip *imx)

{

	struct pwm_imx27_chip *imx = to_pwm_imx27_chip(chip);



	clk_disable_unprepare(imx->clk_per);

	clk_disable_unprepare(imx->clk_ipg);

}
@@ -130,7 +127,7 @@ static void pwm_imx27_get_state(struct pwm_chip *chip, 
	u64 tmp;

	int ret;



	ret = pwm_imx27_clk_prepare_enable(chip);

	ret = pwm_imx27_clk_prepare_enable(imx);

	if (ret < 0)

		return;
@@ -175,7 +172,7 @@ static void pwm_imx27_get_state(struct pwm_chip *chip, 
	state->duty_cycle = DIV_ROUND_CLOSEST_ULL(tmp, pwm_clk);



	if (!state->enabled)

		pwm_imx27_clk_disable_unprepare(chip);

		pwm_imx27_clk_disable_unprepare(imx);

}



static void pwm_imx27_sw_reset(struct pwm_chip *chip)
@@ -259,7 +256,7 @@ static int pwm_imx27_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
	if (cstate.enabled) {

		pwm_imx27_wait_fifo_slot(chip, pwm);

	} else {

		ret = pwm_imx27_clk_prepare_enable(chip);

		ret = pwm_imx27_clk_prepare_enable(imx);

		if (ret)

			return ret;
@@ -290,7 +287,7 @@ static int pwm_imx27_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
	writel(cr, imx->mmio_base + MX3_PWMCR);



	if (!state->enabled)

		pwm_imx27_clk_disable_unprepare(chip);

		pwm_imx27_clk_disable_unprepare(imx);



	return 0;

}
@@ -361,7 +358,7 @@ static int pwm_imx27_remove(struct platform_device *pdev) 


	imx = platform_get_drvdata(pdev);



	pwm_imx27_clk_disable_unprepare(&imx->chip);

	pwm_imx27_clk_disable_unprepare(imx);



	return pwmchip_remove(&imx->chip);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE