Commit 15d4dbd6 authored Feb 09, 2020 by Uwe Kleine-König Committed by Thierry Reding Mar 30, 2020

pwm: imx27: Fix clock handling in pwm_imx27_apply()

pwm_imx27_apply() enables the clocks if the previous PWM state was
disabled. Given that the clocks are supposed to be left on iff the PWM
is running, the decision to disable the clocks at the end of the
function must not depend on the previous state.

Without this fix the enable count of the two affected clocks increases
by one whenever ->apply() changes from one disabled state to another.

Fixes: bd88d319 ("pwm: imx27: Unconditionally write state to hardware")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 2c25b07e

drivers/pwm/pwm-imx27.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -289,7 +289,7 @@ static int pwm_imx27_apply(struct pwm_chip chip, struct pwm_device pwm,

		writel(cr, imx->mmio_base + MX3_PWMCR);

		if (!state->enabled && cstate.enabled)
		if (!state->enabled)
		pwm_imx27_clk_disable_unprepare(chip);

		return 0;

Admin message