Commit a7b43649 authored Nov 25, 2020 by Parav Pandit Committed by Jakub Kicinski Nov 25, 2020

devlink: Make sure devlink instance and port are in same net namespace



When devlink reload operation is not used, netdev of an Ethernet port may
be present in different net namespace than the net namespace of the
devlink instance.

Ensure that both the devlink instance and devlink port netdev are located
in same net namespace.

Fixes: 070c63f2 ("net: devlink: allow to change namespaces during reload")
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent b187c9b4

net/core/devlink.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -782,9 +782,10 @@ static int devlink_nl_port_fill(struct sk_buff msg, struct devlink devlink,
		devlink_port->desired_type))
		goto nla_put_failure_type_locked;
		if (devlink_port->type == DEVLINK_PORT_TYPE_ETH) {
		struct net *net = devlink_net(devlink_port->devlink);
		struct net_device *netdev = devlink_port->type_dev;

		if (netdev &&
		if (netdev && net_eq(net, dev_net(netdev)) &&
		(nla_put_u32(msg, DEVLINK_ATTR_PORT_NETDEV_IFINDEX,
		netdev->ifindex) \|\|
		nla_put_string(msg, DEVLINK_ATTR_PORT_NETDEV_NAME,

Admin message