devlink: Hold rtnl lock while reading netdev attributes (b187c9b4) · Commits · 戴 / test

A netdevice of a devlink port can be moved to different net namespace than its parent devlink instance. This scenario occurs when devlink reload is not used. When netdevice is undergoing migration to net namespace, its ifindex and name may change. In such use case, devlink port query may read stale netdev attributes. Fix it by reading them under rtnl lock. Fixes: ("Introduce devlink infrastructure") Signed-off-by:

Parav Pandit <parav@nvidia.com> Signed-off-by:

Jakub Kicinski <kuba@kernel.org>

net/core/devlink.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -772,6 +772,8 @@ static int devlink_nl_port_fill(struct sk_buff msg, struct devlink devlink,
		if (nla_put_u32(msg, DEVLINK_ATTR_PORT_INDEX, devlink_port->index))
		goto nla_put_failure;

		/* Hold rtnl lock while accessing port's netdev attributes. */
		rtnl_lock();
		spin_lock_bh(&devlink_port->type_lock);
		if (nla_put_u16(msg, DEVLINK_ATTR_PORT_TYPE, devlink_port->type))
		goto nla_put_failure_type_locked;
		@@ -798,6 +800,7 @@ static int devlink_nl_port_fill(struct sk_buff msg, struct devlink devlink,
		goto nla_put_failure_type_locked;
		}
		spin_unlock_bh(&devlink_port->type_lock);
		rtnl_unlock();
		if (devlink_nl_port_attrs_put(msg, devlink_port))
		goto nla_put_failure;
		if (devlink_nl_port_function_attrs_put(msg, devlink_port, extack))
		@@ -808,6 +811,7 @@ static int devlink_nl_port_fill(struct sk_buff msg, struct devlink devlink,

		nla_put_failure_type_locked:
		spin_unlock_bh(&devlink_port->type_lock);
		rtnl_unlock();
		nla_put_failure:
		genlmsg_cancel(msg, hdr);
		return -EMSGSIZE;

Admin message