Commit a682e9c2 authored Dec 10, 2014 by Jan Kara Committed by Linus Torvalds Dec 10, 2014

ncpfs: return proper error from NCP_IOC_SETROOT ioctl



If some error happens in NCP_IOC_SETROOT ioctl, the appropriate error
return value is then (in most cases) just overwritten before we return.
This can result in reporting success to userspace although error happened.

This bug was introduced by commit 2e54eb96 ("BKL: Remove BKL from
ncpfs").  Propagate the errors correctly.

Coverity id: 1226925.

Fixes: 2e54eb96 ("BKL: Remove BKL from ncpfs")
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Petr Vandrovec <petr@vandrovec.name>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6ef4536e

fs/ncpfs/ioctl.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -447,7 +447,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
		result = -EIO;
		}
		}
		result = 0;
		}
		mutex_unlock(&server->root_setup_lock);

Admin message