Commit 2e54eb96 authored by Petr Vandrovec's avatar Petr Vandrovec Committed by Arnd Bergmann
Browse files

BKL: Remove BKL from ncpfs 



Dozen of changes in ncpfs to provide some locking other than BKL.

In readdir cache unlock and mark complete first page as last operation,
so it can be used for synchronization, as code intended.

When updating dentry name on case insensitive filesystems do at least
some basic locking...

Hold i_mutex when updating inode fields.

Push some ncp_conn_is_valid down to ncp_request.  Connection can become
invalid at any moment, and fewer error code paths to test the better.

Use i_size_{read,write} to modify file size.

Set inode's backing_dev_info as ncpfs has its own special bdi.

In ioctl unbreak ioctls invoked on filesystem mounted 'ro' - tests are
for inode writeable or owner match, but were turned to filesystem
writeable and inode writeable or owner match.  Also collect all permission
checks in single place.

Add some locking, and remove comments saying that it would be cool to
add some locks to the code.

Constify some pointers.

Signed-off-by: default avatarPetr Vandrovec <petr@vandrovec.name>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 60056794

fs/ncpfs/dir.c

+129 −92
Original line number Diff line number Diff line
@@ -95,6 +95,34 @@ const struct dentry_operations ncp_root_dentry_operations = 
};





#define ncp_namespace(i)	(NCP_SERVER(i)->name_space[NCP_FINFO(i)->volNumber])



static inline int ncp_preserve_entry_case(struct inode *i, __u32 nscreator)

{

#ifdef CONFIG_NCPFS_SMALLDOS

	int ns = ncp_namespace(i);



	if ((ns == NW_NS_DOS)

#ifdef CONFIG_NCPFS_OS2_NS

		|| ((ns == NW_NS_OS2) && (nscreator == NW_NS_DOS))

#endif /* CONFIG_NCPFS_OS2_NS */

	   )

		return 0;

#endif /* CONFIG_NCPFS_SMALLDOS */

	return 1;

}



#define ncp_preserve_case(i)	(ncp_namespace(i) != NW_NS_DOS)



static inline int ncp_case_sensitive(struct dentry *dentry)

{

#ifdef CONFIG_NCPFS_NFS_NS

	return ncp_namespace(dentry->d_inode) == NW_NS_NFS;

#else

	return 0;

#endif /* CONFIG_NCPFS_NFS_NS */

}



/*

 * Note: leave the hash unchanged if the directory

 * is case-sensitive.
@@ -102,13 +130,12 @@ const struct dentry_operations ncp_root_dentry_operations = 
static int 

ncp_hash_dentry(struct dentry *dentry, struct qstr *this)

{

	if (!ncp_case_sensitive(dentry)) {

		struct nls_table *t;

		unsigned long hash;

		int i;



		t = NCP_IO_TABLE(dentry);



	if (!ncp_case_sensitive(dentry->d_inode)) {

		hash = init_name_hash();

		for (i=0; i<this->len ; i++)

			hash = partial_name_hash(ncp_tolower(t, this->name[i]),
@@ -124,7 +151,7 @@ ncp_compare_dentry(struct dentry *dentry, struct qstr *a, struct qstr *b) 
	if (a->len != b->len)

		return 1;



	if (ncp_case_sensitive(dentry->d_inode))

	if (ncp_case_sensitive(dentry))

		return strncmp(a->name, b->name, a->len);



	return ncp_strnicmp(NCP_IO_TABLE(dentry), a->name, b->name, a->len);
@@ -266,7 +293,7 @@ leave_me:; 




static int

__ncp_lookup_validate(struct dentry *dentry)

ncp_lookup_validate(struct dentry *dentry, struct nameidata *nd)

{

	struct ncp_server *server;

	struct dentry *parent;
@@ -283,9 +310,6 @@ __ncp_lookup_validate(struct dentry *dentry) 


	server = NCP_SERVER(dir);



	if (!ncp_conn_valid(server))

		goto finished;



	/*

	 * Inspired by smbfs:

	 * The default validation is based on dentry age:
@@ -304,8 +328,11 @@ __ncp_lookup_validate(struct dentry *dentry) 
	if (ncp_is_server_root(dir)) {

		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,

				 dentry->d_name.len, 1);

		if (!res)

		if (!res) {

			res = ncp_lookup_volume(server, __name, &(finfo.i));

			if (!res)

				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);

		}

	} else {

		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,

				 dentry->d_name.len, !ncp_preserve_case(dir));
@@ -320,13 +347,17 @@ __ncp_lookup_validate(struct dentry *dentry) 
	 * what we remember, it's not valid any more.

	 */

	if (!res) {

		if (finfo.i.dirEntNum == NCP_FINFO(dentry->d_inode)->dirEntNum) {

		struct inode *inode = dentry->d_inode;



		mutex_lock(&inode->i_mutex);

		if (finfo.i.dirEntNum == NCP_FINFO(inode)->dirEntNum) {

			ncp_new_dentry(dentry);

			val=1;

		} else

			DDPRINTK("ncp_lookup_validate: found, but dirEntNum changed\n");



		ncp_update_inode2(dentry->d_inode, &finfo);

		ncp_update_inode2(inode, &finfo);

		mutex_unlock(&inode->i_mutex);

	}



finished:
@@ -335,16 +366,6 @@ finished: 
	return val;

}



static int

ncp_lookup_validate(struct dentry * dentry, struct nameidata *nd)

{

	int res;

	lock_kernel();

	res = __ncp_lookup_validate(dentry);

	unlock_kernel();

	return res;

}



static struct dentry *

ncp_dget_fpos(struct dentry *dentry, struct dentry *parent, unsigned long fpos)

{
@@ -411,8 +432,6 @@ static int ncp_readdir(struct file *filp, void *dirent, filldir_t filldir) 
	int result, mtime_valid = 0;

	time_t mtime = 0;



	lock_kernel();



	ctl.page  = NULL;

	ctl.cache = NULL;
@@ -421,6 +440,7 @@ static int ncp_readdir(struct file *filp, void *dirent, filldir_t filldir) 
		(int) filp->f_pos);



	result = -EIO;

	/* Do not generate '.' and '..' when server is dead. */

	if (!ncp_conn_valid(server))

		goto out;
@@ -532,6 +552,12 @@ read_really: 
	ctl.head.end = ctl.fpos - 1;

	ctl.head.eof = ctl.valid;

finished:

	if (ctl.page) {

		kunmap(ctl.page);

		SetPageUptodate(ctl.page);

		unlock_page(ctl.page);

		page_cache_release(ctl.page);

	}

	if (page) {

		cache->head = ctl.head;

		kunmap(page);
@@ -539,23 +565,17 @@ finished: 
		unlock_page(page);

		page_cache_release(page);

	}

	if (ctl.page) {

		kunmap(ctl.page);

		SetPageUptodate(ctl.page);

		unlock_page(ctl.page);

		page_cache_release(ctl.page);

	}

out:

	unlock_kernel();

	return result;

}



static int

ncp_fill_cache(struct file *filp, void *dirent, filldir_t filldir,

		struct ncp_cache_control *ctrl, struct ncp_entry_info *entry)

		struct ncp_cache_control *ctrl, struct ncp_entry_info *entry,

		int inval_childs)

{

	struct dentry *newdent, *dentry = filp->f_path.dentry;

	struct inode *newino, *inode = dentry->d_inode;

	struct inode *dir = dentry->d_inode;

	struct ncp_cache_control ctl = *ctrl;

	struct qstr qname;

	int valid = 0;
@@ -564,9 +584,9 @@ ncp_fill_cache(struct file *filp, void *dirent, filldir_t filldir, 
	__u8 __name[NCP_MAXPATHLEN + 1];



	qname.len = sizeof(__name);

	if (ncp_vol2io(NCP_SERVER(inode), __name, &qname.len,

	if (ncp_vol2io(NCP_SERVER(dir), __name, &qname.len,

			entry->i.entryName, entry->i.nameLen,

			!ncp_preserve_entry_case(inode, entry->i.NSCreator)))

			!ncp_preserve_entry_case(dir, entry->i.NSCreator)))

		return 1; /* I'm not sure */



	qname.name = __name;
@@ -584,22 +604,64 @@ ncp_fill_cache(struct file *filp, void *dirent, filldir_t filldir, 
			goto end_advance;

	} else {

		hashed = 1;



		/* If case sensitivity changed for this volume, all entries below this one

		   should be thrown away.  This entry itself is not affected, as its case

		   sensitivity is controlled by its own parent. */

		if (inval_childs)

			shrink_dcache_parent(newdent);



		/*

		 * It is not as dangerous as it looks.  NetWare's OS2 namespace is

		 * case preserving yet case insensitive.  So we update dentry's name

		 * as received from server.  We found dentry via d_lookup with our

		 * hash, so we know that hash does not change, and so replacing name

		 * should be reasonably safe.

		 */

		if (qname.len == newdent->d_name.len &&

		    memcmp(newdent->d_name.name, qname.name, newdent->d_name.len)) {

			struct inode *inode = newdent->d_inode;



			/*

			 * Inside ncpfs all uses of d_name are either for debugging,

			 * or on functions which acquire inode mutex (mknod, creat,

			 * lookup).  So grab i_mutex here, to be sure.  d_path

			 * uses dcache_lock when generating path, so we should too.

			 * And finally d_compare is protected by dentry's d_lock, so

			 * here we go.

			 */

			if (inode)

				mutex_lock(&inode->i_mutex);

			spin_lock(&dcache_lock);

			spin_lock(&newdent->d_lock);

			memcpy((char *) newdent->d_name.name, qname.name,

								newdent->d_name.len);

			spin_unlock(&newdent->d_lock);

			spin_unlock(&dcache_lock);

			if (inode)

				mutex_unlock(&inode->i_mutex);

		}

	}



	if (!newdent->d_inode) {

		struct inode *inode;



		entry->opened = 0;

		entry->ino = iunique(inode->i_sb, 2);

		newino = ncp_iget(inode->i_sb, entry);

		if (newino) {

		entry->ino = iunique(dir->i_sb, 2);

		inode = ncp_iget(dir->i_sb, entry);

		if (inode) {

			newdent->d_op = &ncp_dentry_operations;

			d_instantiate(newdent, newino);

			d_instantiate(newdent, inode);

			if (!hashed)

				d_rehash(newdent);

		}

	} else

		ncp_update_inode2(newdent->d_inode, entry);

	} else {

		struct inode *inode = newdent->d_inode;



		mutex_lock(&inode->i_mutex);

		ncp_update_inode2(inode, entry);

		mutex_unlock(&inode->i_mutex);

	}



	if (newdent->d_inode) {

		ino = newdent->d_inode->i_ino;
@@ -617,7 +679,7 @@ ncp_fill_cache(struct file *filp, void *dirent, filldir_t filldir, 
		ctl.cache = NULL;

		ctl.idx  -= NCP_DIRCACHE_SIZE;

		ctl.ofs  += 1;

		ctl.page  = grab_cache_page(&inode->i_data, ctl.ofs);

		ctl.page  = grab_cache_page(&dir->i_data, ctl.ofs);

		if (ctl.page)

			ctl.cache = kmap(ctl.page);

	}
@@ -633,7 +695,7 @@ end_advance: 
		if (!ino)

			ino = find_inode_number(dentry, &qname);

		if (!ino)

			ino = iunique(inode->i_sb, 2);

			ino = iunique(dir->i_sb, 2);

		ctl.filled = filldir(dirent, qname.name, qname.len,

				     filp->f_pos, ino, DT_UNKNOWN);

		if (!ctl.filled)
@@ -660,6 +722,7 @@ ncp_read_volume_list(struct file *filp, void *dirent, filldir_t filldir, 
			(unsigned long) filp->f_pos);



	for (i = 0; i < NCP_NUMBER_OF_VOLUMES; i++) {

		int inval_dentry;



		if (ncp_get_volume_info_with_number(server, i, &info) != 0)

			return;
@@ -675,8 +738,9 @@ ncp_read_volume_list(struct file *filp, void *dirent, filldir_t filldir, 
				info.volume_name);

			continue;

		}

		inval_dentry = ncp_update_known_namespace(server, entry.i.volNumber, NULL);

		entry.volume = entry.i.volNumber;

		if (!ncp_fill_cache(filp, dirent, filldir, ctl, &entry))

		if (!ncp_fill_cache(filp, dirent, filldir, ctl, &entry, inval_dentry))

			return;

	}

}
@@ -739,7 +803,7 @@ ncp_do_readdir(struct file *filp, void *dirent, filldir_t filldir, 
			rpl += onerpl;

			rpls -= onerpl;

			entry.volume = entry.i.volNumber;

			if (!ncp_fill_cache(filp, dirent, filldir, ctl, &entry))

			if (!ncp_fill_cache(filp, dirent, filldir, ctl, &entry, 0))

				break;

		}

	} while (more);
@@ -775,16 +839,18 @@ int ncp_conn_logged_in(struct super_block *sb) 
		if (dent) {

			struct inode* ino = dent->d_inode;

			if (ino) {

				ncp_update_known_namespace(server, volNumber, NULL);

				NCP_FINFO(ino)->volNumber = volNumber;

				NCP_FINFO(ino)->dirEntNum = dirEntNum;

				NCP_FINFO(ino)->DosDirNum = DosDirNum;

				result = 0;

			} else {

				DPRINTK("ncpfs: sb->s_root->d_inode == NULL!\n");

			}

		} else {

			DPRINTK("ncpfs: sb->s_root == NULL!\n");

		}

	}

	} else

		result = 0;



out:
@@ -799,7 +865,6 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, struc 
	int error, res, len;

	__u8 __name[NCP_MAXPATHLEN + 1];



	lock_kernel();

	error = -EIO;

	if (!ncp_conn_valid(server))

		goto finished;
@@ -813,6 +878,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, struc 
				 dentry->d_name.len, 1);

		if (!res)

			res = ncp_lookup_volume(server, __name, &(finfo.i));

			if (!res)

				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);

	} else {

		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,

				 dentry->d_name.len, !ncp_preserve_case(dir));
@@ -846,7 +913,6 @@ add_entry: 


finished:

	PPRINTK("ncp_lookup: result=%d\n", error);

	unlock_kernel();

	return ERR_PTR(error);

}
@@ -887,11 +953,6 @@ int ncp_create_new(struct inode *dir, struct dentry *dentry, int mode, 
	PPRINTK("ncp_create_new: creating %s/%s, mode=%x\n",

		dentry->d_parent->d_name.name, dentry->d_name.name, mode);



	error = -EIO;

	lock_kernel();

	if (!ncp_conn_valid(server))

		goto out;



	ncp_age_dentry(server, dentry);

	len = sizeof(__name);

	error = ncp_io2vol(server, __name, &len, dentry->d_name.name,
@@ -917,6 +978,8 @@ int ncp_create_new(struct inode *dir, struct dentry *dentry, int mode, 
		if (result) {

			if (result == 0x87)

				error = -ENAMETOOLONG;

			else if (result < 0)

				error = result;

			DPRINTK("ncp_create: %s/%s failed\n",

				dentry->d_parent->d_name.name, dentry->d_name.name);

			goto out;
@@ -935,7 +998,6 @@ int ncp_create_new(struct inode *dir, struct dentry *dentry, int mode, 


	error = ncp_instantiate(dir, dentry, &finfo);

out:

	unlock_kernel();

	return error;

}
@@ -955,11 +1017,6 @@ static int ncp_mkdir(struct inode *dir, struct dentry *dentry, int mode) 
	DPRINTK("ncp_mkdir: making %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);



	error = -EIO;

	lock_kernel();

	if (!ncp_conn_valid(server))

		goto out;



	ncp_age_dentry(server, dentry);

	len = sizeof(__name);

	error = ncp_io2vol(server, __name, &len, dentry->d_name.name,
@@ -967,12 +1024,11 @@ static int ncp_mkdir(struct inode *dir, struct dentry *dentry, int mode) 
	if (error)

		goto out;



	error = -EACCES;

	if (ncp_open_create_file_or_subdir(server, dir, __name,

	error = ncp_open_create_file_or_subdir(server, dir, __name,

					   OC_MODE_CREATE, aDIR,

					   cpu_to_le16(0xffff),

					   &finfo) == 0)

	{

					   &finfo);

	if (error == 0) {

		if (ncp_is_nfs_extras(server, finfo.volume)) {

			mode |= S_IFDIR;

			finfo.i.nfs.mode = mode;
@@ -983,9 +1039,10 @@ static int ncp_mkdir(struct inode *dir, struct dentry *dentry, int mode) 
				goto out;

		}

		error = ncp_instantiate(dir, dentry, &finfo);

	} else if (error > 0) {

		error = -EACCES;

	}

out:

	unlock_kernel();

	return error;

}
@@ -998,11 +1055,6 @@ static int ncp_rmdir(struct inode *dir, struct dentry *dentry) 
	DPRINTK("ncp_rmdir: removing %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);



	error = -EIO;

	lock_kernel();

	if (!ncp_conn_valid(server))

		goto out;



	error = -EBUSY;

	if (!d_unhashed(dentry))

		goto out;
@@ -1036,11 +1088,10 @@ static int ncp_rmdir(struct inode *dir, struct dentry *dentry) 
			error = -ENOENT;

			break;

		default:

			error = -EACCES;

			error = result < 0 ? result : -EACCES;

			break;

       	}

out:

	unlock_kernel();

	return error;

}
@@ -1050,15 +1101,10 @@ static int ncp_unlink(struct inode *dir, struct dentry *dentry) 
	struct ncp_server *server;

	int error;



	lock_kernel();

	server = NCP_SERVER(dir);

	DPRINTK("ncp_unlink: unlinking %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);

	

	error = -EIO;

	if (!ncp_conn_valid(server))

		goto out;



	/*

	 * Check whether to close the file ...

	 */
@@ -1097,12 +1143,9 @@ static int ncp_unlink(struct inode *dir, struct dentry *dentry) 
			error = -ENOENT;

			break;

		default:

			error = -EACCES;

			error = error < 0 ? error : -EACCES;

			break;

	}

		

out:

	unlock_kernel();

	return error;

}
@@ -1118,11 +1161,6 @@ static int ncp_rename(struct inode *old_dir, struct dentry *old_dentry, 
		old_dentry->d_parent->d_name.name, old_dentry->d_name.name,

		new_dentry->d_parent->d_name.name, new_dentry->d_name.name);



	error = -EIO;

	lock_kernel();

	if (!ncp_conn_valid(server))

		goto out;



	ncp_age_dentry(server, old_dentry);

	ncp_age_dentry(server, new_dentry);
@@ -1161,11 +1199,10 @@ static int ncp_rename(struct inode *old_dir, struct dentry *old_dentry, 
			error = -ENOENT;

			break;

		default:

			error = -EACCES;

			error = error < 0 ? error : -EACCES;

			break;

	}

out:

	unlock_kernel();

	return error;

}

fs/ncpfs/file.c

+7 −18
Original line number Diff line number Diff line
@@ -113,9 +113,6 @@ ncp_file_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) 
	DPRINTK("ncp_file_read: enter %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);



	if (!ncp_conn_valid(NCP_SERVER(inode)))

		return -EIO;



	pos = *ppos;



	if ((ssize_t) count < 0) {
@@ -192,13 +189,11 @@ ncp_file_write(struct file *file, const char __user *buf, size_t count, loff_t * 


	DPRINTK("ncp_file_write: enter %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);

	if (!ncp_conn_valid(NCP_SERVER(inode)))

		return -EIO;

	if ((ssize_t) count < 0)

		return -EINVAL;

	pos = *ppos;

	if (file->f_flags & O_APPEND) {

		pos = inode->i_size;

		pos = i_size_read(inode);

	}



	if (pos + count > MAX_NON_LFS && !(file->f_flags&O_LARGEFILE)) {
@@ -264,8 +259,11 @@ ncp_file_write(struct file *file, const char __user *buf, size_t count, loff_t * 


	*ppos = pos;



	if (pos > inode->i_size) {

		inode->i_size = pos;

	if (pos > i_size_read(inode)) {

		mutex_lock(&inode->i_mutex);

		if (pos > i_size_read(inode))

			i_size_write(inode, pos);

		mutex_unlock(&inode->i_mutex);

	}

	DPRINTK("ncp_file_write: exit %s/%s\n",

		dentry->d_parent->d_name.name, dentry->d_name.name);
@@ -281,18 +279,9 @@ static int ncp_release(struct inode *inode, struct file *file) { 
	return 0;

}



static loff_t ncp_remote_llseek(struct file *file, loff_t offset, int origin)

{

	loff_t ret;

	lock_kernel();

	ret = generic_file_llseek_unlocked(file, offset, origin);

	unlock_kernel();

	return ret;

}



const struct file_operations ncp_file_operations =

{

	.llseek 	= ncp_remote_llseek,

	.llseek		= generic_file_llseek,

	.read		= ncp_file_read,

	.write		= ncp_file_write,

	.unlocked_ioctl	= ncp_ioctl,

fs/ncpfs/inode.c

+24 −17
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static void ncp_update_dates(struct inode *inode, struct nw_info_struct *nwi) 
		inode->i_mode = nwi->nfs.mode;

	}



	inode->i_blocks = (inode->i_size + NCP_BLOCK_SIZE - 1) >> NCP_BLOCK_SHIFT;

	inode->i_blocks = (i_size_read(inode) + NCP_BLOCK_SIZE - 1) >> NCP_BLOCK_SHIFT;



	inode->i_mtime.tv_sec = ncp_date_dos2unix(nwi->modifyTime, nwi->modifyDate);

	inode->i_ctime.tv_sec = ncp_date_dos2unix(nwi->creationTime, nwi->creationDate);
@@ -158,18 +158,21 @@ static void ncp_update_attrs(struct inode *inode, struct ncp_entry_info *nwinfo) 
		inode->i_mode = server->m.dir_mode;

		/* for directories dataStreamSize seems to be some

		   Object ID ??? */

		inode->i_size = NCP_BLOCK_SIZE;

		i_size_write(inode, NCP_BLOCK_SIZE);

	} else {

		u32 size;



		inode->i_mode = server->m.file_mode;

		inode->i_size = le32_to_cpu(nwi->dataStreamSize);

		size = le32_to_cpu(nwi->dataStreamSize);

		i_size_write(inode, size);

#ifdef CONFIG_NCPFS_EXTRAS

		if ((server->m.flags & (NCP_MOUNT_EXTRAS|NCP_MOUNT_SYMLINKS)) 

		 && (nwi->attributes & aSHARED)) {

			switch (nwi->attributes & (aHIDDEN|aSYSTEM)) {

				case aHIDDEN:

					if (server->m.flags & NCP_MOUNT_SYMLINKS) {

						if (/* (inode->i_size >= NCP_MIN_SYMLINK_SIZE)

						 && */ (inode->i_size <= NCP_MAX_SYMLINK_SIZE)) {

						if (/* (size >= NCP_MIN_SYMLINK_SIZE)

						 && */ (size <= NCP_MAX_SYMLINK_SIZE)) {

							inode->i_mode = (inode->i_mode & ~S_IFMT) | S_IFLNK;

							NCP_FINFO(inode)->flags |= NCPI_KLUDGE_SYMLINK;

							break;
@@ -208,7 +211,7 @@ void ncp_update_inode2(struct inode* inode, struct ncp_entry_info *nwinfo) 
}



/*

 * Fill in the inode based on the ncp_entry_info structure.

 * Fill in the inode based on the ncp_entry_info structure.  Used only for brand new inodes.

 */

static void ncp_set_attr(struct inode *inode, struct ncp_entry_info *nwinfo)

{
@@ -254,6 +257,7 @@ ncp_iget(struct super_block *sb, struct ncp_entry_info *info) 
	if (inode) {

		atomic_set(&NCP_FINFO(inode)->opened, info->opened);



		inode->i_mapping->backing_dev_info = sb->s_bdi;

		inode->i_ino = info->ino;

		ncp_set_attr(inode, info);

		if (S_ISREG(inode->i_mode)) {
@@ -565,10 +569,12 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
/*	server->conn_status = 0;	*/

/*	server->root_dentry = NULL;	*/

/*	server->root_setuped = 0;	*/

	mutex_init(&server->root_setup_lock);

#ifdef CONFIG_NCPFS_PACKET_SIGNING

/*	server->sign_wanted = 0;	*/

/*	server->sign_active = 0;	*/

#endif

	init_rwsem(&server->auth_rwsem);

	server->auth.auth_type = NCP_AUTH_NONE;

/*	server->auth.object_name_len = 0;	*/

/*	server->auth.object_name = NULL;	*/
@@ -593,7 +599,7 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
	server->nls_io = load_nls_default();

#endif /* CONFIG_NCPFS_NLS */



	server->dentry_ttl = 0;	/* no caching */

	atomic_set(&server->dentry_ttl, 0);	/* no caching */



	INIT_LIST_HEAD(&server->tx.requests);

	mutex_init(&server->rcv.creq_mutex);
@@ -658,8 +664,10 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
				goto out_disconnect;

			}

		}

		ncp_lock_server(server);

		if (options & 2)

			server->sign_wanted = 1;

		ncp_unlock_server(server);

	}

	else 

#endif	/* CONFIG_NCPFS_PACKET_SIGNING */
@@ -720,6 +728,9 @@ out_nls: 
	unload_nls(server->nls_io);

	unload_nls(server->nls_vol);

#endif

	mutex_destroy(&server->rcv.creq_mutex);

	mutex_destroy(&server->root_setup_lock);

	mutex_destroy(&server->mutex);

out_fput2:

	if (server->info_filp)

		fput(server->info_filp);
@@ -743,8 +754,6 @@ static void ncp_put_super(struct super_block *sb) 
{

	struct ncp_server *server = NCP_SBP(sb);



	lock_kernel();



	ncp_lock_server(server);

	ncp_disconnect(server);

	ncp_unlock_server(server);
@@ -756,6 +765,9 @@ static void ncp_put_super(struct super_block *sb) 
	unload_nls(server->nls_vol);

	unload_nls(server->nls_io);

#endif /* CONFIG_NCPFS_NLS */

	mutex_destroy(&server->rcv.creq_mutex);

	mutex_destroy(&server->root_setup_lock);

	mutex_destroy(&server->mutex);



	if (server->info_filp)

		fput(server->info_filp);
@@ -771,8 +783,6 @@ static void ncp_put_super(struct super_block *sb) 
	vfree(server->packet);

	sb->s_fs_info = NULL;

	kfree(server);



	unlock_kernel();

}



static int ncp_statfs(struct dentry *dentry, struct kstatfs *buf)
@@ -851,10 +861,8 @@ int ncp_notify_change(struct dentry *dentry, struct iattr *attr) 


	result = -EIO;



	lock_kernel();	



	server = NCP_SERVER(inode);

	if ((!server) || !ncp_conn_valid(server))

	if (!server)	/* How this could happen? */

		goto out;



	/* ageing the dentry to force validation */
@@ -981,8 +989,6 @@ int ncp_notify_change(struct dentry *dentry, struct iattr *attr) 
		result = ncp_modify_file_or_subdir_dos_info(NCP_SERVER(inode),

				      inode, info_mask, &info);

		if (result != 0) {

			result = -EACCES;



			if (info_mask == (DM_CREATE_TIME | DM_CREATE_DATE)) {

				/* NetWare seems not to allow this. I

				   do not know why. So, just tell the
@@ -1005,7 +1011,8 @@ int ncp_notify_change(struct dentry *dentry, struct iattr *attr) 
	mark_inode_dirty(inode);



out:

	unlock_kernel();

	if (result > 0)

		result = -EACCES;

	return result;

}

fs/ncpfs/ioctl.c

+255 −215

File changed.

Preview size limit exceeded, changes collapsed.

fs/ncpfs/ncplib_kernel.c

+56 −45
Original line number Diff line number Diff line
@@ -107,17 +107,17 @@ ncp_reply_data(struct ncp_server *server, int offset) 
	return &(server->packet[sizeof(struct ncp_reply_header) + offset]);

}



static inline u8 BVAL(void *data)

static inline u8 BVAL(const void *data)

{

	return *(u8 *)data;

	return *(const u8 *)data;

}



static u8 ncp_reply_byte(struct ncp_server *server, int offset)

{

	return *(u8 *)ncp_reply_data(server, offset);

	return *(const u8 *)ncp_reply_data(server, offset);

}



static inline u16 WVAL_LH(void *data)

static inline u16 WVAL_LH(const void *data)

{

	return get_unaligned_le16(data);

}
@@ -134,7 +134,7 @@ ncp_reply_be16(struct ncp_server *server, int offset) 
	return get_unaligned_be16(ncp_reply_data(server, offset));

}



static inline u32 DVAL_LH(void *data)

static inline u32 DVAL_LH(const void *data)

{

	return get_unaligned_le32(data);

}
@@ -349,9 +349,9 @@ int ncp_dirhandle_free(struct ncp_server* server, __u8 dirhandle) { 
	return result;

}



void ncp_extract_file_info(void *structure, struct nw_info_struct *target)

void ncp_extract_file_info(const void *structure, struct nw_info_struct *target)

{

	__u8 *name_len;

	const __u8 *name_len;

	const int info_struct_size = offsetof(struct nw_info_struct, nameLen);



	memcpy(target, structure, info_struct_size);
@@ -364,7 +364,7 @@ void ncp_extract_file_info(void *structure, struct nw_info_struct *target) 
}



#ifdef CONFIG_NCPFS_NFS_NS

static inline void ncp_extract_nfs_info(unsigned char *structure,

static inline void ncp_extract_nfs_info(const unsigned char *structure,

				 struct nw_nfs_info *target)

{

	target->mode = DVAL_LH(structure);
@@ -417,7 +417,7 @@ int ncp_obtain_nfs_info(struct ncp_server *server, 
 * Returns information for a (one-component) name relative to

 * the specified directory.

 */

int ncp_obtain_info(struct ncp_server *server, struct inode *dir, char *path,

int ncp_obtain_info(struct ncp_server *server, struct inode *dir, const char *path,

			struct nw_info_struct *target)

{

	__u8  volnum = NCP_FINFO(dir)->volNumber;
@@ -452,16 +452,16 @@ out: 
#ifdef CONFIG_NCPFS_NFS_NS

static int

ncp_obtain_DOS_dir_base(struct ncp_server *server,

		__u8 volnum, __le32 dirent,

		char *path, /* At most 1 component */

		__u8 ns, __u8 volnum, __le32 dirent,

		const char *path, /* At most 1 component */

		__le32 *DOS_dir_base)

{

	int result;



	ncp_init_request(server);

	ncp_add_byte(server, 6); /* subfunction */

	ncp_add_byte(server, server->name_space[volnum]);

	ncp_add_byte(server, server->name_space[volnum]);

	ncp_add_byte(server, ns);

	ncp_add_byte(server, ns);

	ncp_add_word(server, cpu_to_le16(0x8006)); /* get all */

	ncp_add_dword(server, RIM_DIRECTORY);

	ncp_add_handle_path(server, volnum, dirent, 1, path);
@@ -523,10 +523,27 @@ ncp_get_known_namespace(struct ncp_server *server, __u8 volume) 
#endif	/* defined(CONFIG_NCPFS_OS2_NS) || defined(CONFIG_NCPFS_NFS_NS) */

}



int

ncp_update_known_namespace(struct ncp_server *server, __u8 volume, int *ret_ns)

{

	int ns = ncp_get_known_namespace(server, volume);



	if (ret_ns)

		*ret_ns = ns;



	DPRINTK("lookup_vol: namespace[%d] = %d\n",

		volume, server->name_space[volume]);



	if (server->name_space[volume] == ns)

		return 0;

	server->name_space[volume] = ns;

	return 1;

}



static int

ncp_ObtainSpecificDirBase(struct ncp_server *server,

		__u8 nsSrc, __u8 nsDst, __u8 vol_num, __le32 dir_base,

		char *path, /* At most 1 component */

		const char *path, /* At most 1 component */

		__le32 *dirEntNum, __le32 *DosDirNum)

{

	int result;
@@ -561,13 +578,12 @@ ncp_mount_subdir(struct ncp_server *server, 
	int dstNS;

	int result;



	dstNS = ncp_get_known_namespace(server, volNumber);

	ncp_update_known_namespace(server, volNumber, &dstNS);

	if ((result = ncp_ObtainSpecificDirBase(server, srcNS, dstNS, volNumber, 

				      dirEntNum, NULL, newDirEnt, newDosEnt)) != 0)

	{

		return result;

	}

	server->name_space[volNumber] = dstNS;

	*volume = volNumber;

	server->m.mounted_vol[1] = 0;

	server->m.mounted_vol[0] = 'X';
@@ -575,11 +591,10 @@ ncp_mount_subdir(struct ncp_server *server, 
}



int 

ncp_get_volume_root(struct ncp_server *server, const char *volname,

		    __u32* volume, __le32* dirent, __le32* dosdirent)

ncp_get_volume_root(struct ncp_server *server,

		    const char *volname, __u32* volume, __le32* dirent, __le32* dosdirent)

{

	int result;

	__u8 volnum;



	DPRINTK("ncp_get_volume_root: looking up vol %s\n", volname);
@@ -601,21 +616,14 @@ ncp_get_volume_root(struct ncp_server *server, const char *volname, 
		return result;

	}

	*dirent = *dosdirent = ncp_reply_dword(server, 4);

	volnum = ncp_reply_byte(server, 8);

	*volume = ncp_reply_byte(server, 8);

	ncp_unlock_server(server);

	*volume = volnum;



	server->name_space[volnum] = ncp_get_known_namespace(server, volnum);



	DPRINTK("lookup_vol: namespace[%d] = %d\n",

		volnum, server->name_space[volnum]);



	return 0;

}



int

ncp_lookup_volume(struct ncp_server *server, const char *volname,

		  struct nw_info_struct *target)

ncp_lookup_volume(struct ncp_server *server,

		  const char *volname, struct nw_info_struct *target)

{

	int result;
@@ -625,6 +633,7 @@ ncp_lookup_volume(struct ncp_server *server, const char *volname, 
	if (result) {

		return result;

	}

	ncp_update_known_namespace(server, target->volNumber, NULL);

	target->nameLen = strlen(volname);

	memcpy(target->entryName, volname, target->nameLen+1);

	target->attributes = aDIR;
@@ -676,8 +685,8 @@ int ncp_modify_nfs_info(struct ncp_server *server, __u8 volnum, __le32 dirent, 
{

	int result = 0;



	if (server->name_space[volnum] == NW_NS_NFS) {

	ncp_init_request(server);

	if (server->name_space[volnum] == NW_NS_NFS) {

		ncp_add_byte(server, 25);	/* subfunction */

		ncp_add_byte(server, server->name_space[volnum]);

		ncp_add_byte(server, NW_NS_NFS);
@@ -690,8 +699,8 @@ int ncp_modify_nfs_info(struct ncp_server *server, __u8 volnum, __le32 dirent, 
		ncp_add_dword_lh(server, 1);	/* nlinks */

		ncp_add_dword_lh(server, rdev);

		result = ncp_request(server, 87);

		ncp_unlock_server(server);

	}

	ncp_unlock_server(server);

	return result;

}

#endif
@@ -700,7 +709,7 @@ int ncp_modify_nfs_info(struct ncp_server *server, __u8 volnum, __le32 dirent, 
static int

ncp_DeleteNSEntry(struct ncp_server *server,

		  __u8 have_dir_base, __u8 volnum, __le32 dirent,

		  char* name, __u8 ns, __le16 attr)

		  const char* name, __u8 ns, __le16 attr)

{

	int result;
@@ -734,23 +743,25 @@ ncp_del_file_or_subdir2(struct ncp_server *server, 


int

ncp_del_file_or_subdir(struct ncp_server *server,

		       struct inode *dir, char *name)

		       struct inode *dir, const char *name)

{

	__u8  volnum = NCP_FINFO(dir)->volNumber;

	__le32 dirent = NCP_FINFO(dir)->dirEntNum;

	int name_space;



	name_space = server->name_space[volnum];

#ifdef CONFIG_NCPFS_NFS_NS

	if (server->name_space[volnum]==NW_NS_NFS)

	if (name_space == NW_NS_NFS)

 	{

 		int result;

 

 		result=ncp_obtain_DOS_dir_base(server, volnum, dirent, name, &dirent);

		result=ncp_obtain_DOS_dir_base(server, name_space, volnum, dirent, name, &dirent);

 		if (result) return result;

 		return ncp_DeleteNSEntry(server, 1, volnum, dirent, NULL, NW_NS_DOS, cpu_to_le16(0x8006));

		name = NULL;

		name_space = NW_NS_DOS;

 	}

 	else

#endif	/* CONFIG_NCPFS_NFS_NS */

 		return ncp_DeleteNSEntry(server, 1, volnum, dirent, name, server->name_space[volnum], cpu_to_le16(0x8006));

	return ncp_DeleteNSEntry(server, 1, volnum, dirent, name, name_space, cpu_to_le16(0x8006));

}



static inline void ConvertToNWfromDWORD(__u16 v0, __u16 v1, __u8 ret[6])
@@ -765,7 +776,7 @@ static inline void ConvertToNWfromDWORD(__u16 v0, __u16 v1, __u8 ret[6]) 
/* If both dir and name are NULL, then in target there's already a

   looked-up entry that wants to be opened. */

int ncp_open_create_file_or_subdir(struct ncp_server *server,

				   struct inode *dir, char *name,

				   struct inode *dir, const char *name,

				   int open_create_mode,

				   __le32 create_attributes,

				   __le16 desired_acc_rights,
@@ -890,8 +901,8 @@ int ncp_search_for_fileset(struct ncp_server *server, 


static int

ncp_RenameNSEntry(struct ncp_server *server,

		  struct inode *old_dir, char *old_name, __le16 old_type,

		  struct inode *new_dir, char *new_name)

		  struct inode *old_dir, const char *old_name, __le16 old_type,

		  struct inode *new_dir, const char *new_name)

{

	int result = -EINVAL;
@@ -929,8 +940,8 @@ out: 
}



int ncp_ren_or_mov_file_or_subdir(struct ncp_server *server,

				struct inode *old_dir, char *old_name,

				struct inode *new_dir, char *new_name)

				struct inode *old_dir, const char *old_name,

				struct inode *new_dir, const char *new_name)

{

        int result;

        __le16 old_type = cpu_to_le16(0x06);
@@ -958,7 +969,7 @@ int 
ncp_read_kernel(struct ncp_server *server, const char *file_id,

	     __u32 offset, __u16 to_read, char *target, int *bytes_read)

{

	char *source;

	const char *source;

	int result;



	ncp_init_request(server);

CRA Git | Maintained and supported by SUSTech CRA and CCSE