pwm: meson: Don't disable PWM when setting duty repeatedly (a2793458) · Commits · 戴 / test

There is an abnormally low about 20ms,when setting duty repeatedly. Because setting the duty will disable PWM and then enable. Delete this operation now. Fixes: ("pwm: Add support for Meson PWM Controller") Signed-off-by:

Bichao Zheng <bichao.zheng@amlogic.com> [ Dropped code instead of hiding it behind a comment ] Signed-off-by:

Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by:

Neil Armstrong <narmstrong@baylibre.com> Signed-off-by:

Thierry Reding <thierry.reding@gmail.com>

drivers/pwm/pwm-meson.c

+0 −5

Original line number	Original line	Diff line number	Diff line
	@@ -314,11 +314,6 @@ static int meson_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
	if (state->period != channel->state.period \|\|		if (state->period != channel->state.period \|\|
	state->duty_cycle != channel->state.duty_cycle \|\|		state->duty_cycle != channel->state.duty_cycle \|\|
	state->polarity != channel->state.polarity) {		state->polarity != channel->state.polarity) {
	if (channel->state.enabled) {
	meson_pwm_disable(meson, pwm->hwpwm);
	channel->state.enabled = false;
	}

	if (state->polarity != channel->state.polarity) {		if (state->polarity != channel->state.polarity) {
	if (state->polarity == PWM_POLARITY_NORMAL)		if (state->polarity == PWM_POLARITY_NORMAL)
	meson->inverter_mask \|= BIT(pwm->hwpwm);		meson->inverter_mask \|= BIT(pwm->hwpwm);

Admin message