Commit a10b5c56 authored Aug 14, 2017 by Byungchul Park Committed by Ingo Molnar Aug 14, 2017

locking/lockdep: Add a comment about crossrelease_hist_end() in lockdep_sys_exit()



In lockdep_sys_exit(), crossrelease_hist_end() is called unconditionally
even when getting here without having started e.g. just after forking.

But it's no problem since it would roll back to an invalid entry anyway.
Add a comment to explain this.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: akpm@linux-foundation.org
Cc: boqun.feng@gmail.com
Cc: kernel-team@lge.com
Cc: kirill@shutemov.name
Cc: linux-mm@kvack.org
Cc: npiggin@gmail.com
Cc: walken@google.com
Cc: willy@infradead.org
Link: http://lkml.kernel.org/r/1502694052-16085-2-git-send-email-byungchul.park@lge.com


[ Improved the description and the comments. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent ccde85ba

kernel/locking/lockdep.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -4623,6 +4623,10 @@ asmlinkage __visible void lockdep_sys_exit(void)
		/*
		* The lock history for each syscall should be independent. So wipe the
		* slate clean on return to userspace.
		*
		* crossrelease_hist_end() works well here even when getting here
		* without starting (i.e. just after forking), because it rolls back
		* the index to point to the last entry, which is already invalid.
		*/
		crossrelease_hist_end(XHLOCK_PROC);
		crossrelease_hist_start(XHLOCK_PROC);

Admin message