mm, locking: Fix up flush_tlb_pending() related merge in do_huge_pmd_numa_page() (ccde85ba) · Commits · 戴 / test

Merge commit: ("Merge branch 'linus' into locking/core, to resolve conflicts") overlooked the fact that do_huge_pmd_numa_page() now does two TLB flushes. Commit: ("mm, locking: Rework {set,clear,mm}_tlb_flush_pending()") and commit: ("Revert "mm: numa: defer TLB flush for THP migration as long as possible"") Both moved the TLB flush around but slightly different, the end result being that what was one became two. Clean this up. Signed-off-by:

Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: David S. Miller <davem@davemloft.net> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mel Gorman <mgorman@suse.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Rik van Riel <riel@redhat.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: Will Deacon <will.deacon@arm.com> Cc: linux-kernel@vger.kernel.org Signed-off-by:

Ingo Molnar <mingo@kernel.org>

mm/huge_memory.c

+5 −17

Original line number	Diff line number	Diff line
		@@ -1410,7 +1410,6 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
		unsigned long haddr = vmf->address & HPAGE_PMD_MASK;
		int page_nid = -1, this_nid = numa_node_id();
		int target_nid, last_cpupid = -1;
		bool need_flush = false;
		bool page_locked;
		bool migrated = false;
		bool was_writable;
		@@ -1496,23 +1495,19 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
		goto clear_pmdnuma;
		}

		/*
		* The page_table_lock above provides a memory barrier
		* with change_protection_range.
		*/
		if (mm_tlb_flush_pending(vma->vm_mm))
		flush_tlb_range(vma, haddr, haddr + HPAGE_PMD_SIZE);

		/*
		* Since we took the NUMA fault, we must have observed the !accessible
		* bit. Make sure all other CPUs agree with that, to avoid them
		* modifying the page we're about to migrate.
		*
		* Must be done under PTL such that we'll observe the relevant
		* set_tlb_flush_pending().
		* inc_tlb_flush_pending().
		*
		* We are not sure a pending tlb flush here is for a huge page
		* mapping or not. Hence use the tlb range variant
		*/
		if (mm_tlb_flush_pending(vma->vm_mm))
		need_flush = true;
		flush_tlb_range(vma, haddr, haddr + HPAGE_PMD_SIZE);

		/*
		* Migrate the THP to the requested node, returns with page unlocked
		@@ -1520,13 +1515,6 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
		*/
		spin_unlock(vmf->ptl);

		/*
		* We are not sure a pending tlb flush here is for a huge page
		* mapping or not. Hence use the tlb range variant
		*/
		if (need_flush)
		flush_tlb_range(vma, haddr, haddr + HPAGE_PMD_SIZE);

		migrated = migrate_misplaced_transhuge_page(vma->vm_mm, vma,
		vmf->pmd, pmd, vmf->address, page, target_nid);
		if (migrated) {

Admin message