Commit a08aa355 authored May 24, 2011 by Ilia Mirkin Committed by Linus Torvalds May 25, 2011

lru_cache: use correct type in sizeof for allocation



This has no actual effect, since sizeof(struct hlist_head) ==
sizeof(struct hlist_head *), but it's still the wrong type to use.

The semantic match that finds this problem:
// <smpl>
@@
type T;
identifier x;
@@
T *x;
...
* x = kzalloc(... * sizeof(T*) * ..., ...);
// </smpl>

[akpm@linux-foundation.org: use kcalloc()]
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Acked-by: Lars Ellenberg <lars@linbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4440673a

lib/lru_cache.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ struct lru_cache lc_create(const char name, struct kmem_cache *cache,
		if (e_count > LC_MAX_ACTIVE)
		return NULL;

		slot = kzalloc(e_count * sizeof(struct hlist_head*), GFP_KERNEL);
		slot = kcalloc(e_count, sizeof(struct hlist_head), GFP_KERNEL);
		if (!slot)
		goto out_fail;
		element = kzalloc(e_count * sizeof(struct lc_element *), GFP_KERNEL);

Admin message