Commit 4440673a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Linus Torvalds
Browse files

leds: provide helper to register "leds-gpio" devices 



This function makes a deep copy of the platform data to allow it to live
in init memory.  For a kernel that supports several machines and so
includes the definition for several leds-gpio devices this saves quite
some memory because all but one definition can be free'd after boot.

As the function is used by arch code it must be builtin and so cannot go
into leds-gpio.c.

[akpm@linux-foundation.org: s/CONFIG_LED_REGISTER_GPIO/CONFIG_LEDS_REGISTER_GPIO/]
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Russell King <rmk@arm.linux.org.uk>
Acked-by: default avatarRichard Purdie <richard.purdie@linuxfoundation.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Tested-by: default avatarH Hartley Sweeten <hartleys@visionengravers.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9b2da53f

drivers/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ obj-$(CONFIG_CPU_IDLE) += cpuidle/ 
obj-$(CONFIG_DMA_ENGINE)	+= dma/

obj-$(CONFIG_MMC)		+= mmc/

obj-$(CONFIG_MEMSTICK)		+= memstick/

obj-$(CONFIG_NEW_LEDS)		+= leds/

obj-y				+= leds/

obj-$(CONFIG_INFINIBAND)	+= infiniband/

obj-$(CONFIG_SGI_SN)		+= sn/

obj-y				+= firmware/

drivers/leds/Kconfig

+7 −0
Original line number Diff line number Diff line
@@ -14,6 +14,13 @@ config LEDS_CLASS 
	  This option enables the led sysfs class in /sys/class/leds.  You'll

	  need this to do anything useful with LEDs.  If unsure, say N.



config LEDS_GPIO_REGISTER

	bool

	help

	  This option provides the function gpio_led_register_device.

	  As this function is used by arch code it must not be compiled as a

	  module.



if NEW_LEDS



comment "LED drivers"

drivers/leds/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ obj-$(CONFIG_LEDS_COBALT_QUBE) += leds-cobalt-qube.o 
obj-$(CONFIG_LEDS_COBALT_RAQ)		+= leds-cobalt-raq.o

obj-$(CONFIG_LEDS_SUNFIRE)		+= leds-sunfire.o

obj-$(CONFIG_LEDS_PCA9532)		+= leds-pca9532.o

obj-$(CONFIG_LEDS_GPIO_REGISTER)	+= leds-gpio-register.o

obj-$(CONFIG_LEDS_GPIO)			+= leds-gpio.o

obj-$(CONFIG_LEDS_LP3944)		+= leds-lp3944.o

obj-$(CONFIG_LEDS_LP5521)		+= leds-lp5521.o

drivers/leds/leds-gpio-register.c

0 → 100644
+42 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2011 Pengutronix

 * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>

 *

 * This program is free software; you can redistribute it and/or modify it under

 * the terms of the GNU General Public License version 2 as published by the

 * Free Software Foundation.

 */

#include <linux/err.h>

#include <linux/platform_device.h>

#include <linux/slab.h>

#include <linux/leds.h>



/**

 * gpio_led_register_device - register a gpio-led device

 * @pdata: the platform data used for the new device

 *

 * Makes a copy of pdata and pdata->leds and registers a new leds-gpio device

 * with the result. This allows to have pdata and pdata-leds in .init.rodata

 * and so saves some bytes compared to a static struct platform_device with

 * static platform data.

 *

 * Returns the registered device or an error pointer.

 */

struct platform_device *__init gpio_led_register_device(

		int id, const struct gpio_led_platform_data *pdata)

{

	struct platform_device *ret;

	struct gpio_led_platform_data _pdata = *pdata;



	_pdata.leds = kmemdup(pdata->leds,

			pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL);

	if (!_pdata.leds)

		return ERR_PTR(-ENOMEM);



	ret = platform_device_register_resndata(NULL, "leds-gpio", id,

			NULL, 0, &_pdata, sizeof(_pdata));

	if (IS_ERR(ret))

		kfree(_pdata.leds);



	return ret;

}

include/linux/leds.h

+2 −0
Original line number Diff line number Diff line
@@ -207,5 +207,7 @@ struct gpio_led_platform_data { 
					unsigned long *delay_off);

};



struct platform_device *gpio_led_register_device(

		int id, const struct gpio_led_platform_data *pdata);



#endif		/* __LINUX_LEDS_H_INCLUDED */

CRA Git | Maintained and supported by SUSTech CRA and CCSE