Unverified Commit a026525d authored by Sowjanya Komatineni's avatar Sowjanya Komatineni Committed by Mark Brown
Browse files

spi: tegra114: avoid reset call in atomic context 



This patch moves SPI controller reset out of spin lock.

Signed-off-by: default avatarSowjanya Komatineni <skomatineni@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f3e182c3

drivers/spi/spi-tegra114.c

+5 −4
Original line number Diff line number Diff line
@@ -967,11 +967,12 @@ static irqreturn_t handle_cpu_based_xfer(struct tegra_spi_data *tspi) 
		dev_err(tspi->dev, "CpuXfer 0x%08x:0x%08x\n",

			tspi->command1_reg, tspi->dma_control_reg);

		tegra_spi_flush_fifos(tspi);

		complete(&tspi->xfer_completion);

		spin_unlock_irqrestore(&tspi->lock, flags);

		reset_control_assert(tspi->rst);

		udelay(2);

		reset_control_deassert(tspi->rst);

		complete(&tspi->xfer_completion);

		goto exit;

		return IRQ_HANDLED;

	}



	if (tspi->cur_direction & DATA_DIR_RX)
@@ -1040,11 +1041,11 @@ static irqreturn_t handle_dma_based_xfer(struct tegra_spi_data *tspi) 
		dev_err(tspi->dev, "DmaXfer 0x%08x:0x%08x\n",

			tspi->command1_reg, tspi->dma_control_reg);

		tegra_spi_flush_fifos(tspi);

		complete(&tspi->xfer_completion);

		spin_unlock_irqrestore(&tspi->lock, flags);

		reset_control_assert(tspi->rst);

		udelay(2);

		reset_control_deassert(tspi->rst);

		complete(&tspi->xfer_completion);

		spin_unlock_irqrestore(&tspi->lock, flags);

		return IRQ_HANDLED;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE