Commit 9d648fb5 authored Mar 24, 2020 by Vladyslav Tarasiuk Committed by David S. Miller Mar 24, 2020

ethtool: fix incorrect tx-checksumming settings reporting



Currently, ethtool feature mask for checksum command is ORed with
NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the
actual feature bit - NETIF_F_FCOE_CRC.

The invalid bitmask here might affect unrelated features when toggling
TX checksumming. For example, TX checksumming is always mistakenly
reported as enabled on the netdevs tested (mlx5, virtio_net).

Fixes: f70bb065 ("ethtool: update mapping of features to legacy ioctl requests")
Signed-off-by: Vladyslav Tarasiuk <vladyslavt@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c9c1fd62

net/ethtool/ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -196,7 +196,7 @@ static netdev_features_t ethtool_get_feature_mask(u32 eth_cmd)
		switch (eth_cmd) {
		case ETHTOOL_GTXCSUM:
		case ETHTOOL_STXCSUM:
		return NETIF_F_CSUM_MASK \| NETIF_F_FCOE_CRC_BIT \|
		return NETIF_F_CSUM_MASK \| NETIF_F_FCOE_CRC \|
		NETIF_F_SCTP_CRC;
		case ETHTOOL_GRXCSUM:
		case ETHTOOL_SRXCSUM:

Admin message