Commit f70bb065 authored Mar 12, 2020 by Michal Kubecek Committed by David S. Miller Mar 12, 2020

ethtool: update mapping of features to legacy ioctl requests



Legacy ioctl request like ETHTOOL_GTXCSUM are still used by ethtool utility
to get values of legacy flags (which rather work as feature groups). These
are calculated from values of actual features and request to set them is
implemented as an attempt to set all features mapping to them but there are
two inconsistencies:

- tx-checksum-fcoe-crc is shown under tx-checksumming but NETIF_F_FCOE_CRC
  is not included in ETHTOOL_GTXCSUM/ETHTOOL_STXCSUM
- tx-scatter-gather-fraglist is shown under scatter-gather but
  NETIF_F_FRAGLIST is not included in ETHTOOL_GSG/ETHTOOL_SSG

As the mapping in ethtool output is more correct from logical point of
view, fix ethtool_get_feature_mask() to match it.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 98130546

net/ethtool/ioctl.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -198,13 +198,14 @@ static netdev_features_t ethtool_get_feature_mask(u32 eth_cmd)
		switch (eth_cmd) {
		case ETHTOOL_GTXCSUM:
		case ETHTOOL_STXCSUM:
		return NETIF_F_CSUM_MASK \| NETIF_F_SCTP_CRC;
		return NETIF_F_CSUM_MASK \| NETIF_F_FCOE_CRC_BIT \|
		NETIF_F_SCTP_CRC;
		case ETHTOOL_GRXCSUM:
		case ETHTOOL_SRXCSUM:
		return NETIF_F_RXCSUM;
		case ETHTOOL_GSG:
		case ETHTOOL_SSG:
		return NETIF_F_SG;
		return NETIF_F_SG \| NETIF_F_FRAGLIST;
		case ETHTOOL_GTSO:
		case ETHTOOL_STSO:
		return NETIF_F_ALL_TSO;

Admin message