Commit 9a05e754 authored Nov 18, 2016 by Tobias Klauser Committed by Jens Axboe Nov 18, 2016

block: Change extern inline to static inline



With compilers which follow the C99 standard (like modern versions of
gcc and clang), "extern inline" does the opposite thing from older
versions of gcc (emits code for an externally linkable version of the
inline function).

"static inline" does the intended behavior in all cases instead.

Description taken from commit 6d91857d ("staging, rtl8192e,
LLVMLinux: Change extern inline to static inline").

This also fixes the following GCC warning when building with CONFIG_PM
disabled:

  ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes]

Fixes: d07ab6d1 ("block: Add blk_set_runtime_active()")
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 55f958cc

include/linux/blkdev.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -1174,7 +1174,7 @@ static inline int blk_pre_runtime_suspend(struct request_queue *q)
		static inline void blk_post_runtime_suspend(struct request_queue *q, int err) {}
		static inline void blk_pre_runtime_resume(struct request_queue *q) {}
		static inline void blk_post_runtime_resume(struct request_queue *q, int err) {}
		extern inline void blk_set_runtime_active(struct request_queue *q) {}
		static inline void blk_set_runtime_active(struct request_queue *q) {}
		#endif

		/*

Admin message