Commit d07ab6d1 authored by Mika Westerberg's avatar Mika Westerberg Committed by Tejun Heo
Browse files

block: Add blk_set_runtime_active() 



If block device is left runtime suspended during system suspend, resume
hook of the driver typically corrects runtime PM status of the device back
to "active" after it is resumed. However, this is not enough as queue's
runtime PM status is still "suspended". As long as it is in this state
blk_pm_peek_request() returns NULL and thus prevents new requests to be
processed.

Add new function blk_set_runtime_active() that can be used to force the
queue status back to "active" as needed.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 15d3ce7b

block/blk-core.c

+24 −0
Original line number Diff line number Diff line
@@ -3527,6 +3527,30 @@ void blk_post_runtime_resume(struct request_queue *q, int err) 
	spin_unlock_irq(q->queue_lock);

}

EXPORT_SYMBOL(blk_post_runtime_resume);



/**

 * blk_set_runtime_active - Force runtime status of the queue to be active

 * @q: the queue of the device

 *

 * If the device is left runtime suspended during system suspend the resume

 * hook typically resumes the device and corrects runtime status

 * accordingly. However, that does not affect the queue runtime PM status

 * which is still "suspended". This prevents processing requests from the

 * queue.

 *

 * This function can be used in driver's resume hook to correct queue

 * runtime PM status and re-enable peeking requests from the queue. It

 * should be called before first request is added to the queue.

 */

void blk_set_runtime_active(struct request_queue *q)

{

	spin_lock_irq(q->queue_lock);

	q->rpm_status = RPM_ACTIVE;

	pm_runtime_mark_last_busy(q->dev);

	pm_request_autosuspend(q->dev);

	spin_unlock_irq(q->queue_lock);

}

EXPORT_SYMBOL(blk_set_runtime_active);

#endif



int __init blk_dev_init(void)

include/linux/blkdev.h

+2 −0
Original line number Diff line number Diff line
@@ -1026,6 +1026,7 @@ extern int blk_pre_runtime_suspend(struct request_queue *q); 
extern void blk_post_runtime_suspend(struct request_queue *q, int err);

extern void blk_pre_runtime_resume(struct request_queue *q);

extern void blk_post_runtime_resume(struct request_queue *q, int err);

extern void blk_set_runtime_active(struct request_queue *q);

#else

static inline void blk_pm_runtime_init(struct request_queue *q,

	struct device *dev) {}
@@ -1036,6 +1037,7 @@ static inline int blk_pre_runtime_suspend(struct request_queue *q) 
static inline void blk_post_runtime_suspend(struct request_queue *q, int err) {}

static inline void blk_pre_runtime_resume(struct request_queue *q) {}

static inline void blk_post_runtime_resume(struct request_queue *q, int err) {}

extern inline void blk_set_runtime_active(struct request_queue *q) {}

#endif



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE