Commit 991454e1 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: core: remove pointless auxiliary from snd_soc_component 



commit 1a653aa4 ("ASoC: core: replace aux_comp_list to ...")
tried to replace aux_comp_list to component_dev_list,
but it failed because of binding timing. Thus, Sylwester fixuped it by
commit d2e3a135 ("ASoC: Fix binding and probing of auxiliary...").

One of main purpose of commit 1a653aa4 ("ASoC: core: replace...")
was remove replaceable list (= list_aux) from snd_soc_component by using
new "auxiliary" flags (but it failed).
Because of this background, current code has reborned card_aux_list
(= same as original list_aux), and almost pointless "auxiliary" flags.

Let's remove pointless "auxiliary" flags by this patch
This means, it is same as revert both
commit 1a653aa4 ("ASoC: core: replace aux_comp_list to ...") and
commit d2e3a135 ("ASoC: Fix binding and probing of auxiliary...").

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ec5a82d6

include/sound/soc.h

+0 −1
Original line number Diff line number Diff line
@@ -812,7 +812,6 @@ struct snd_soc_component { 


	unsigned int ignore_pmdown_time:1; /* pmdown_time is ignored at stop */

	unsigned int registered_as_component:1;

	unsigned int auxiliary:1; /* for auxiliary component of the card */

	unsigned int suspended:1; /* is in suspend PM state */



	struct list_head list;

sound/soc/soc-core.c

+5 −10
Original line number Diff line number Diff line
@@ -1776,7 +1776,6 @@ static int soc_bind_aux_dev(struct snd_soc_card *card, int num) 
	}



	component->init = aux_dev->init;

	component->auxiliary = 1;

	list_add(&component->card_aux_list, &card->aux_comp_list);



	return 0;
@@ -1788,14 +1787,13 @@ err_defer: 


static int soc_probe_aux_devices(struct snd_soc_card *card)

{

	struct snd_soc_component *comp, *tmp;

	struct snd_soc_component *comp;

	int order;

	int ret;



	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;

		order++) {

		list_for_each_entry_safe(comp, tmp, &card->aux_comp_list,

					 card_aux_list) {

		list_for_each_entry(comp, &card->aux_comp_list, card_aux_list) {

			if (comp->driver->probe_order == order) {

				ret = soc_probe_component(card,	comp);

				if (ret < 0) {
@@ -1804,7 +1802,6 @@ static int soc_probe_aux_devices(struct snd_soc_card *card) 
						comp->name, ret);

					return ret;

				}

				list_del(&comp->card_aux_list);

			}

		}

	}
@@ -1820,14 +1817,12 @@ static void soc_remove_aux_devices(struct snd_soc_card *card) 
	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;

		order++) {

		list_for_each_entry_safe(comp, _comp,

			&card->component_dev_list, card_list) {



			if (!comp->auxiliary)

				continue;

			&card->aux_comp_list, card_aux_list) {



			if (comp->driver->remove_order == order) {

				soc_remove_component(comp);

				comp->auxiliary = 0;

				/* remove it from the card's aux_comp_list */

				list_del(&comp->card_aux_list);

			}

		}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE