Commit d2e3a135 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mark Brown
Browse files

ASoC: Fix binding and probing of auxiliary components 



Currently binding of auxiliary devices doesn't work as in
soc_bind_aux_dev() function a bound component is not being added
to any list and in soc_probe_aux_devices() we are trying to walk
the component_dev_list list to probe auxiliary components but
at that time this list doesn't contain any auxiliary components
since they are being added to the card only in soc_probe_component().

This patch adds a list to the card where are stored bound but not
probed auxiliary devices, so that all aux devices can be probed.

Fixes: 1a653aa4 "ASoC: core: replace aux_comp_list to component_dev_list"
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5de5b74

include/sound/soc.h

+3 −0
Original line number Diff line number Diff line
@@ -813,6 +813,7 @@ struct snd_soc_component { 
	unsigned int suspended:1; /* is in suspend PM state */



	struct list_head list;

	struct list_head card_aux_list; /* for auxiliary bound components */

	struct list_head card_list;



	struct snd_soc_dai_driver *dai_drv;
@@ -1152,6 +1153,7 @@ struct snd_soc_card { 
	 */

	struct snd_soc_aux_dev *aux_dev;

	int num_aux_devs;

	struct list_head aux_comp_list;



	const struct snd_kcontrol_new *controls;

	int num_controls;
@@ -1547,6 +1549,7 @@ static inline void snd_soc_initialize_card_lists(struct snd_soc_card *card) 
	INIT_LIST_HEAD(&card->widgets);

	INIT_LIST_HEAD(&card->paths);

	INIT_LIST_HEAD(&card->dapm_list);

	INIT_LIST_HEAD(&card->aux_comp_list);

	INIT_LIST_HEAD(&card->component_dev_list);

}

sound/soc/soc-core.c

+5 −5
Original line number Diff line number Diff line
@@ -1748,6 +1748,7 @@ static int soc_bind_aux_dev(struct snd_soc_card *card, int num) 


	component->init = aux_dev->init;

	component->auxiliary = 1;

	list_add(&component->card_aux_list, &card->aux_comp_list);



	return 0;
@@ -1758,16 +1759,14 @@ err_defer: 


static int soc_probe_aux_devices(struct snd_soc_card *card)

{

	struct snd_soc_component *comp;

	struct snd_soc_component *comp, *tmp;

	int order;

	int ret;



	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;

		order++) {

		list_for_each_entry(comp, &card->component_dev_list, card_list) {

			if (!comp->auxiliary)

				continue;



		list_for_each_entry_safe(comp, tmp, &card->aux_comp_list,

					 card_aux_list) {

			if (comp->driver->probe_order == order) {

				ret = soc_probe_component(card,	comp);

				if (ret < 0) {
@@ -1776,6 +1775,7 @@ static int soc_probe_aux_devices(struct snd_soc_card *card) 
						comp->name, ret);

					return ret;

				}

				list_del(&comp->card_aux_list);

			}

		}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE