Commit 97944769 authored Oct 17, 2019 by Roger Quadros Committed by Greg Kroah-Hartman Oct 18, 2019

usb: cdns3: Error out if USB_DR_MODE_UNKNOWN in cdns3_core_init_role()



USB_DR_MODE_UNKNOWN should be treated as error as it is done in
cdns3_drd_update_mode().

Fixes: 02ffc26d ("usb: cdns3: fix cdns3_core_init_role()")
Signed-off-by: Roger Quadros <rogerq@ti.com>
Link: https://lore.kernel.org/r/20191017075801.8734-1-rogerq@ti.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7a6f22d7

drivers/usb/cdns3/core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -166,7 +166,6 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
		goto err;

		switch (cdns->dr_mode) {
		case USB_DR_MODE_UNKNOWN:
		case USB_DR_MODE_OTG:
		ret = cdns3_hw_role_switch(cdns);
		if (ret)
		@@ -182,6 +181,9 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
		if (ret)
		goto err;
		break;
		default:
		ret = -EINVAL;
		goto err;
		}

		return ret;

Admin message