Commit 02ffc26d authored Oct 07, 2019 by Roger Quadros Committed by Greg Kroah-Hartman Oct 10, 2019

usb: cdns3: fix cdns3_core_init_role()



At startup we should trigger the HW state machine
only if it is OTG mode. Otherwise we should just
start the respective role.

Initialize idle role by default. If we don't do this then
cdns3_idle_role_stop() is not called when switching to
host/device role and so lane switch mechanism
doesn't work. This results to super-speed device not working
in one orientation if it was plugged before driver probe.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Link: https://lore.kernel.org/r/20191007121601.25996-2-rogerq@ti.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ac9099e1

drivers/usb/cdns3/core.c

+19 −1

Original line number	Original line	Diff line number	Diff line
	@@ -160,10 +160,28 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
	if (ret)		if (ret)
	goto err;		goto err;

	if (cdns->dr_mode != USB_DR_MODE_OTG) {		/* Initialize idle role to start with */
			ret = cdns3_role_start(cdns, USB_ROLE_NONE);
			if (ret)
			goto err;

			switch (cdns->dr_mode) {
			case USB_DR_MODE_UNKNOWN:
			case USB_DR_MODE_OTG:
	ret = cdns3_hw_role_switch(cdns);		ret = cdns3_hw_role_switch(cdns);
	if (ret)		if (ret)
	goto err;		goto err;
			break;
			case USB_DR_MODE_PERIPHERAL:
			ret = cdns3_role_start(cdns, USB_ROLE_DEVICE);
			if (ret)
			goto err;
			break;
			case USB_DR_MODE_HOST:
			ret = cdns3_role_start(cdns, USB_ROLE_HOST);
			if (ret)
			goto err;
			break;
	}		}

	return ret;		return ret;

Admin message