Commit 97069788 authored by Andy Grover's avatar Andy Grover Committed by David S. Miller
Browse files

RDS: Turn down alarming reconnect messages 



RDS's error messages when a connection goes down are a little
extreme. A connection may go down, and it will be re-established,
and everything is fine. This patch links these messages through
rdsdebug(), instead of to printk directly.

Signed-off-by: default avatarAndy Grover <andy.grover@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 571c02fa

net/rds/ib_cm.c

+2 −1
Original line number Diff line number Diff line
@@ -203,9 +203,10 @@ static void rds_ib_qp_event_handler(struct ib_event *event, void *data) 
		rdma_notify(ic->i_cm_id, IB_EVENT_COMM_EST);

		break;

	default:

		rds_ib_conn_error(conn, "RDS/IB: Fatal QP Event %u "

		rdsdebug("Fatal QP Event %u "

			"- connection %pI4->%pI4, reconnecting\n",

			event->event, &conn->c_laddr, &conn->c_faddr);

		rds_conn_drop(conn);

		break;

	}

}

net/rds/iw_cm.c

+3 −1
Original line number Diff line number Diff line
@@ -156,9 +156,11 @@ static void rds_iw_qp_event_handler(struct ib_event *event, void *data) 
	case IB_EVENT_QP_REQ_ERR:

	case IB_EVENT_QP_FATAL:

	default:

		rds_iw_conn_error(conn, "RDS/IW: Fatal QP Event %u - connection %pI4->%pI4...reconnecting\n",

		rdsdebug("Fatal QP Event %u "

			"- connection %pI4->%pI4, reconnecting\n",

			event->event, &conn->c_laddr,

			&conn->c_faddr);

		rds_conn_drop(conn);

		break;

	}

}

net/rds/rdma_transport.c

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id, 
		break;



	case RDMA_CM_EVENT_DISCONNECTED:

		printk(KERN_WARNING "RDS/RDMA: DISCONNECT event - dropping connection "

		rdsdebug("DISCONNECT event - dropping connection "

			"%pI4->%pI4\n", &conn->c_laddr,

			 &conn->c_faddr);

		rds_conn_drop(conn);

CRA Git | Maintained and supported by SUSTech CRA and CCSE