Commit 571c02fa authored Mar 11, 2010 by Andy Grover Committed by David S. Miller Mar 16, 2010

RDS: Workaround for in-use MRs on close causing crash



if a machine is shut down without closing sockets properly, and
freeing all MRs, then a BUG_ON will bring it down. This patch
changes these to WARN_ONs -- leaking MRs is not fatal (although
not ideal, and there is more work to do here for a proper fix.)

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 048c15e6

net/rds/ib_rdma.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -234,8 +234,8 @@ void rds_ib_destroy_mr_pool(struct rds_ib_mr_pool *pool)
		{
		flush_workqueue(rds_wq);
		rds_ib_flush_mr_pool(pool, 1);
		BUG_ON(atomic_read(&pool->item_count));
		BUG_ON(atomic_read(&pool->free_pinned));
		WARN_ON(atomic_read(&pool->item_count));
		WARN_ON(atomic_read(&pool->free_pinned));
		kfree(pool);
		}

Admin message