Commit 93abad36 authored Jan 17, 2018 by Lucas Stach Committed by Stephen Boyd Mar 16, 2018

clk: imx: pllv2: avoid using uninitialized values



Forward the errors returned by __clk_pllv2_set_rate() in the recalc rate
function, to avoid using uninitialized values for the rate calculation.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent cc4d07a4

drivers/clk/imx/clk-pllv2.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -182,8 +182,12 @@ static long clk_pllv2_round_rate(struct clk_hw *hw, unsigned long rate,
		unsigned long *prate)
		{
		u32 dp_op, dp_mfd, dp_mfn;
		int ret;

		ret = __clk_pllv2_set_rate(rate, *prate, &dp_op, &dp_mfd, &dp_mfn);
		if (ret)
		return ret;

		__clk_pllv2_set_rate(rate, *prate, &dp_op, &dp_mfd, &dp_mfn);
		return __clk_pllv2_recalc_rate(*prate, MXC_PLL_DP_CTL_DPDCK0_2_EN,
		dp_op, dp_mfd, dp_mfn);
		}

Admin message