Commit 928dfb2c authored Sep 12, 2013 by Jingoo Han Committed by Lee Jones Oct 23, 2013

mfd: sm501: Remove unnecessary pci_set_drvdata()



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 1fcd5d81

drivers/mfd/sm501.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1660,7 +1660,6 @@ static int sm501_pci_probe(struct pci_dev *dev,
		err3:
		pci_disable_device(dev);
		err2:
		pci_set_drvdata(dev, NULL);
		kfree(sm);
		err1:
		return err;
		@@ -1695,7 +1694,6 @@ static void sm501_pci_remove(struct pci_dev *dev)
		release_resource(sm->regs_claim);
		kfree(sm->regs_claim);

		pci_set_drvdata(dev, NULL);
		pci_disable_device(dev);
		}

Admin message