mfd: lpc_ich: Remove unnecessary pci_set_drvdata() (1fcd5d81) · Commits · 戴 / test

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by:

Jingoo Han <jg1.han@samsung.com> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/lpc_ich.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -969,7 +969,6 @@ static int lpc_ich_probe(struct pci_dev *dev,
		if (!cell_added) {
		dev_warn(&dev->dev, "No MFD cells added\n");
		lpc_ich_restore_config_space(dev);
		pci_set_drvdata(dev, NULL);
		return -ENODEV;
		}

		@@ -980,7 +979,6 @@ static void lpc_ich_remove(struct pci_dev *dev)
		{
		mfd_remove_devices(&dev->dev);
		lpc_ich_restore_config_space(dev);
		pci_set_drvdata(dev, NULL);
		}

		static struct pci_driver lpc_ich_driver = {

Admin message