Commit 92568145 authored Oct 07, 2020 by Karol Herbst Committed by Ben Skeggs Oct 30, 2020

drm/nouveau/gem: fix "refcount_t: underflow; use-after-free"



we can't use nouveau_bo_ref here as no ttm object was allocated and
nouveau_bo_ref mainly deals with that. Simply deallocate the object.

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 24d9422e

drivers/gpu/drm/nouveau/nouveau_gem.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -190,7 +190,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
		* to the caller, instead of a normal nouveau_bo ttm reference. */
		ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
		if (ret) {
		nouveau_bo_ref(NULL, &nvbo);
		drm_gem_object_release(&nvbo->bo.base);
		kfree(nvbo);
		return ret;
		}

Admin message