Commit 24d9422e authored by Lyude Paul's avatar Lyude Paul Committed by Ben Skeggs
Browse files

drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps 



Not entirely sure why this never came up when I originally tested this
(maybe some BIOSes already have this setup?) but the ->caps_init vfunc
appears to cause the display engine to throw an exception on driver
init, at least on my ThinkPad P72:

nouveau 0000:01:00.0: disp: chid 0 mthd 008c data 00000000 0000508c 0000102b

This is magic nvidia speak for "You need to have the DMA notifier offset
programmed before you can call NV507D_GET_CAPABILITIES." So, let's fix
this by doing that, and also perform an update afterwards to prevent
racing with the GPU when reading capabilities.

v2:
* Don't just program the DMA notifier offset, make sure to actually
  perform an update
v3:
* Don't call UPDATE()
* Actually read the correct notifier fields, as apparently the
  CAPABILITIES_DONE field lives in a different location than the main
  NV_DISP_CORE_NOTIFIER_1 field. As well, 907d+ use a different
  CAPABILITIES_DONE field then pre-907d cards.
v4:
* Don't forget to check the return value of core507d_read_caps()
v5:
* Get rid of NV50_DISP_CAPS_NTFY[14], use NV50_DISP_CORE_NTFY
* Disable notifier after calling GetCapabilities()

Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Fixes: 4a2cb418 ("drm/nouveau/kms/nv50-: Probe SOR and PIOR caps for DP interlacing support")
Cc: <stable@vger.kernel.org> # v5.8+
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent cfa736f5

drivers/gpu/drm/nouveau/dispnv50/core.h

+2 −0
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ int core507d_new_(const struct nv50_core_func *, struct nouveau_drm *, s32, 
		  struct nv50_core **);

int core507d_init(struct nv50_core *);

void core507d_ntfy_init(struct nouveau_bo *, u32);

int core507d_read_caps(struct nv50_disp *disp);

int core507d_caps_init(struct nouveau_drm *, struct nv50_disp *);

int core507d_ntfy_wait_done(struct nouveau_bo *, u32, struct nvif_device *);

int core507d_update(struct nv50_core *, u32 *, bool);
@@ -55,6 +56,7 @@ extern const struct nv50_outp_func pior507d; 
int core827d_new(struct nouveau_drm *, s32, struct nv50_core **);



int core907d_new(struct nouveau_drm *, s32, struct nv50_core **);

int core907d_caps_init(struct nouveau_drm *drm, struct nv50_disp *disp);

extern const struct nv50_outp_func dac907d;

extern const struct nv50_outp_func sor907d;

drivers/gpu/drm/nouveau/dispnv50/core507d.c

+39 −2
Original line number Diff line number Diff line
@@ -78,18 +78,55 @@ core507d_ntfy_init(struct nouveau_bo *bo, u32 offset) 
}



int

core507d_caps_init(struct nouveau_drm *drm, struct nv50_disp *disp)

core507d_read_caps(struct nv50_disp *disp)

{

	struct nvif_push *push = disp->core->chan.push;

	int ret;



	if ((ret = PUSH_WAIT(push, 2)))

	ret = PUSH_WAIT(push, 6);

	if (ret)

		return ret;



	PUSH_MTHD(push, NV507D, SET_NOTIFIER_CONTROL,

		  NVDEF(NV507D, SET_NOTIFIER_CONTROL, MODE, WRITE) |

		  NVVAL(NV507D, SET_NOTIFIER_CONTROL, OFFSET, NV50_DISP_CORE_NTFY >> 2) |

		  NVDEF(NV507D, SET_NOTIFIER_CONTROL, NOTIFY, ENABLE));



	PUSH_MTHD(push, NV507D, GET_CAPABILITIES, 0x00000000);



	PUSH_MTHD(push, NV507D, SET_NOTIFIER_CONTROL,

		  NVDEF(NV507D, SET_NOTIFIER_CONTROL, NOTIFY, DISABLE));



	return PUSH_KICK(push);

}



int

core507d_caps_init(struct nouveau_drm *drm, struct nv50_disp *disp)

{

	struct nv50_core *core = disp->core;

	struct nouveau_bo *bo = disp->sync;

	s64 time;

	int ret;



	NVBO_WR32(bo, NV50_DISP_CORE_NTFY, NV_DISP_CORE_NOTIFIER_1, CAPABILITIES_1,

				     NVDEF(NV_DISP_CORE_NOTIFIER_1, CAPABILITIES_1, DONE, FALSE));



	ret = core507d_read_caps(disp);

	if (ret < 0)

		return ret;



	time = nvif_msec(core->chan.base.device, 2000ULL,

			 if (NVBO_TD32(bo, NV50_DISP_CORE_NTFY,

				       NV_DISP_CORE_NOTIFIER_1, CAPABILITIES_1, DONE, ==, TRUE))

				 break;

			 usleep_range(1, 2);

			 );

	if (time < 0)

		NV_ERROR(drm, "core caps notifier timeout\n");



	return 0;

}



int

core507d_init(struct nv50_core *core)

{

drivers/gpu/drm/nouveau/dispnv50/core907d.c

+35 −1
Original line number Diff line number Diff line
@@ -22,11 +22,45 @@ 
#include "core.h"

#include "head.h"



#include <nvif/push507c.h>

#include <nvif/timer.h>



#include <nvhw/class/cl907d.h>



#include "nouveau_bo.h"



int

core907d_caps_init(struct nouveau_drm *drm, struct nv50_disp *disp)

{

	struct nv50_core *core = disp->core;

	struct nouveau_bo *bo = disp->sync;

	s64 time;

	int ret;



	NVBO_WR32(bo, NV50_DISP_CORE_NTFY, NV907D_CORE_NOTIFIER_3, CAPABILITIES_4,

				     NVDEF(NV907D_CORE_NOTIFIER_3, CAPABILITIES_4, DONE, FALSE));



	ret = core507d_read_caps(disp);

	if (ret < 0)

		return ret;



	time = nvif_msec(core->chan.base.device, 2000ULL,

			 if (NVBO_TD32(bo, NV50_DISP_CORE_NTFY,

				       NV907D_CORE_NOTIFIER_3, CAPABILITIES_4, DONE, ==, TRUE))

				 break;

			 usleep_range(1, 2);

			 );

	if (time < 0)

		NV_ERROR(drm, "core caps notifier timeout\n");



	return 0;

}



static const struct nv50_core_func

core907d = {

	.init = core507d_init,

	.ntfy_init = core507d_ntfy_init,

	.caps_init = core507d_caps_init,

	.caps_init = core907d_caps_init,

	.ntfy_wait_done = core507d_ntfy_wait_done,

	.update = core507d_update,

	.head = &head907d,

drivers/gpu/drm/nouveau/dispnv50/core917d.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static const struct nv50_core_func 
core917d = {

	.init = core507d_init,

	.ntfy_init = core507d_ntfy_init,

	.caps_init = core507d_caps_init,

	.caps_init = core907d_caps_init,

	.ntfy_wait_done = core507d_ntfy_wait_done,

	.update = core507d_update,

	.head = &head917d,

drivers/gpu/drm/nouveau/include/nvhw/class/cl507d.h

+4 −1
Original line number Diff line number Diff line
@@ -32,7 +32,10 @@ 
#define NV_DISP_CORE_NOTIFIER_1_COMPLETION_0_DONE_TRUE                               0x00000001

#define NV_DISP_CORE_NOTIFIER_1_COMPLETION_0_R0                                      15:1

#define NV_DISP_CORE_NOTIFIER_1_COMPLETION_0_TIMESTAMP                               29:16



#define NV_DISP_CORE_NOTIFIER_1_CAPABILITIES_1                                       0x00000001

#define NV_DISP_CORE_NOTIFIER_1_CAPABILITIES_1_DONE                                  0:0

#define NV_DISP_CORE_NOTIFIER_1_CAPABILITIES_1_DONE_FALSE                            0x00000000

#define NV_DISP_CORE_NOTIFIER_1_CAPABILITIES_1_DONE_TRUE                             0x00000001



// class methods

#define NV507D_UPDATE                                                           (0x00000080)

CRA Git | Maintained and supported by SUSTech CRA and CCSE