Unverified Commit 900ccdcb authored Nov 06, 2020 by Zhang Qilong Committed by Mark Brown Nov 06, 2020

spi: stm32: fix reference leak in stm32_spi_resume



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in stm32_spi_resume, so we should fix it.

Fixes: db96bf97 ("spi: stm32: fixes suspend/resume management")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
Link: https://lore.kernel.org/r/20201106015217.140476-1-zhangqilong3@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent c02bb16b

drivers/spi/spi-stm32.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2062,6 +2062,7 @@ static int stm32_spi_resume(struct device *dev)

		ret = pm_runtime_get_sync(dev);
		if (ret < 0) {
		pm_runtime_put_noidle(dev);
		dev_err(dev, "Unable to power device:%d\n", ret);
		return ret;
		}

Admin message