Unverified Commit c02bb16b authored Nov 03, 2020 by Zhang Qilong Committed by Mark Brown Nov 04, 2020

spi: spi-mem: fix reference leak in spi_mem_access_start



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in spi_mem_access_start, so we should fix it.

Fixes: f86c24f4 ("spi: spi-mem: Split spi_mem_exec_op() code")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103140910.3482-1-zhangqilong3@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent a9c52d42

drivers/spi/spi-mem.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -243,6 +243,7 @@ static int spi_mem_access_start(struct spi_mem *mem)

		ret = pm_runtime_get_sync(ctlr->dev.parent);
		if (ret < 0) {
		pm_runtime_put_noidle(ctlr->dev.parent);
		dev_err(&ctlr->dev, "Failed to power device: %d\n",
		ret);
		return ret;

Admin message