net: libertas libertas_tf: Remove in_interrupt() from debug macro. (8faee701) · Commits · 戴 / test

The debug macro prints (INT) when in_interrupt() returns true. The value of this information is dubious as it does not distinguish between the various contexts which are covered by in_interrupt(). As the usage of in_interrupt() in drivers is phased out and the same information can be more precisely obtained with tracing, remove the in_interrupt() conditional from this debug printk. Signed-off-by:

Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by:

Thomas Gleixner <tglx@linutronix.de> Acked-by:

Kalle Valo <kvalo@codeaurora.org> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/wireless/marvell/libertas/defs.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -50,8 +50,7 @@ extern unsigned int lbs_debug;
		#ifdef DEBUG
		#define LBS_DEB_LL(grp, grpnam, fmt, args...) \
		do { if ((lbs_debug & (grp)) == (grp)) \
		printk(KERN_DEBUG DRV_NAME grpnam "%s: " fmt, \
		in_interrupt() ? " (INT)" : "", ## args); } while (0)
		printk(KERN_DEBUG DRV_NAME grpnam ": " fmt, ## args); } while (0)
		#else
		#define LBS_DEB_LL(grp, grpnam, fmt, args...) do {} while (0)
		#endif

drivers/net/wireless/marvell/libertas_tf/deb_defs.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -48,8 +48,7 @@ extern unsigned int lbtf_debug;
		#ifdef DEBUG
		#define LBTF_DEB_LL(grp, grpnam, fmt, args...) \
		do { if ((lbtf_debug & (grp)) == (grp)) \
		printk(KERN_DEBUG DRV_NAME grpnam "%s: " fmt, \
		in_interrupt() ? " (INT)" : "", ## args); } while (0)
		printk(KERN_DEBUG DRV_NAME grpnam ": " fmt, ## args); } while (0)
		#else
		#define LBTF_DEB_LL(grp, grpnam, fmt, args...) do {} while (0)
		#endif

Admin message