Commit d36981e0 authored Sep 29, 2020 by Sebastian Andrzej Siewior Committed by David S. Miller Sep 29, 2020

net: mwifiex: Use netif_rx_any_context().



The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.

mwifiex uses in_interupt() to select the netif_rx*() variant which matches
the calling context. The attempt to consolidate the code by passing an
arguemnt or by distangling it failed due lack of knowledge about this
driver and because the call chains are hard to follow.

As a stop gap use netif_rx_any_context() which invokes the correct code
path depending on context and confines the in_interrupt() usage to core
code.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 75fd2963

drivers/net/wireless/marvell/mwifiex/uap_txrx.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -350,11 +350,7 @@ int mwifiex_uap_recv_packet(struct mwifiex_private *priv,
		skb->truesize += (skb->len - MWIFIEX_RX_DATA_BUF_SIZE);

		/* Forward multicast/broadcast packet to upper layer*/
		if (in_interrupt())
		netif_rx(skb);
		else
		netif_rx_ni(skb);

		netif_rx_any_context(skb);
		return 0;
		}

drivers/net/wireless/marvell/mwifiex/util.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -488,11 +488,7 @@ int mwifiex_recv_packet(struct mwifiex_private priv, struct sk_buff skb)
		(skb->truesize > MWIFIEX_RX_DATA_BUF_SIZE))
		skb->truesize += (skb->len - MWIFIEX_RX_DATA_BUF_SIZE);

		if (in_interrupt())
		netif_rx(skb);
		else
		netif_rx_ni(skb);

		netif_rx_any_context(skb);
		return 0;
		}

Admin message