ionic: start queues before announcing link up (8f56bc4d) · Commits · 戴 / test

Change the order of operations in the link_up handling to be sure that the queues are up and ready before we announce that the link is up. Signed-off-by:

Shannon Nelson <snelson@pensando.io> Reviewed-by:

Saeed Mahameed <saeedm@nvidia.com> Signed-off-by:

Jakub Kicinski <kuba@kernel.org>

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -123,6 +123,12 @@ static void ionic_link_status_check(struct ionic_lif *lif)
		link_up = link_status == IONIC_PORT_OPER_STATUS_UP;

		if (link_up) {
		if (lif->netdev->flags & IFF_UP && netif_running(lif->netdev)) {
		mutex_lock(&lif->queue_lock);
		ionic_start_queues(lif);
		mutex_unlock(&lif->queue_lock);
		}

		if (!netif_carrier_ok(netdev)) {
		u32 link_speed;

		@@ -132,12 +138,6 @@ static void ionic_link_status_check(struct ionic_lif *lif)
		link_speed / 1000);
		netif_carrier_on(netdev);
		}

		if (lif->netdev->flags & IFF_UP && netif_running(lif->netdev)) {
		mutex_lock(&lif->queue_lock);
		ionic_start_queues(lif);
		mutex_unlock(&lif->queue_lock);
		}
		} else {
		if (netif_carrier_ok(netdev)) {
		netdev_info(netdev, "Link down\n");

Admin message