net: macb: Fix passing zero to 'PTR_ERR' (9e6cad53) · Commits · 戴 / test

Check PTR_ERR with IS_ERR to fix this. Signed-off-by:

drivers/net/ethernet/cadence/macb_main.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -3711,19 +3711,13 @@ static int macb_clk_init(struct platform_device pdev, struct clk *pclk,
		}

		if (IS_ERR_OR_NULL(*pclk)) {
		err = PTR_ERR(*pclk);
		if (!err)
		err = -ENODEV;

		err = IS_ERR(pclk) ? PTR_ERR(pclk) : -ENODEV;
		dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);
		return err;
		}

		if (IS_ERR_OR_NULL(*hclk)) {
		err = PTR_ERR(*hclk);
		if (!err)
		err = -ENODEV;

		err = IS_ERR(hclk) ? PTR_ERR(hclk) : -ENODEV;
		dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);
		return err;
		}