Commit 8ee03163 authored Sep 06, 2017 by Tuomas Tynkkynen Committed by Al Viro Oct 23, 2017

fs/9p: Compare qid.path in v9fs_test_inode

Commit fd2421f5 ("fs/9p: When doing inode lookup compare qid details
and inode mode bits.") transformed v9fs_qid_iget() to use iget5_locked()
instead of iget_locked(). However, the test() callback is not checking
fid.path at all, which means that a lookup in the inode cache can now
accidentally locate a completely wrong inode from the same inode hash
bucket if the other fields (qid.type and qid.version) match.

Fixes: fd2421f5 ("fs/9p: When doing inode lookup compare qid details and inode mode bits.")
Cc: stable@vger.kernel.org
Reviewed-by: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 357fdad0

fs/9p/vfs_inode.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -483,6 +483,9 @@ static int v9fs_test_inode(struct inode inode, void data)

		if (v9inode->qid.type != st->qid.type)
		return 0;

		if (v9inode->qid.path != st->qid.path)
		return 0;
		return 1;
		}

fs/9p/vfs_inode_dotl.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -87,6 +87,9 @@ static int v9fs_test_inode_dotl(struct inode inode, void data)

		if (v9inode->qid.type != st->qid.type)
		return 0;

		if (v9inode->qid.path != st->qid.path)
		return 0;
		return 1;
		}

Admin message