Commit fd2421f5 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Eric Van Hensbergen
Browse files

fs/9p: When doing inode lookup compare qid details and inode mode bits. 



This make sure we don't use wrong inode from the inode hash. The inode number
of the file deleted is reused by the next file system object created
and if we only use inode number for inode hash lookup we could end up
with wrong struct inode.

Also compare inode generation number. Not all Linux file system provide
st_gen in userspace. So it could be 0;

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent 5034990e

fs/9p/cache.c

+9 −11
Original line number Diff line number Diff line
@@ -108,11 +108,10 @@ static uint16_t v9fs_cache_inode_get_key(const void *cookie_netfs_data, 
					 void *buffer, uint16_t bufmax)

{

	const struct v9fs_inode *v9inode = cookie_netfs_data;

	memcpy(buffer, &v9inode->fscache_key->path,

	       sizeof(v9inode->fscache_key->path));

	memcpy(buffer, &v9inode->qid.path, sizeof(v9inode->qid.path));

	P9_DPRINTK(P9_DEBUG_FSC, "inode %p get key %llu", &v9inode->vfs_inode,

		   v9inode->fscache_key->path);

	return sizeof(v9inode->fscache_key->path);

		   v9inode->qid.path);

	return sizeof(v9inode->qid.path);

}



static void v9fs_cache_inode_get_attr(const void *cookie_netfs_data,
@@ -129,11 +128,10 @@ static uint16_t v9fs_cache_inode_get_aux(const void *cookie_netfs_data, 
					 void *buffer, uint16_t buflen)

{

	const struct v9fs_inode *v9inode = cookie_netfs_data;

	memcpy(buffer, &v9inode->fscache_key->version,

	       sizeof(v9inode->fscache_key->version));

	memcpy(buffer, &v9inode->qid.version, sizeof(v9inode->qid.version));

	P9_DPRINTK(P9_DEBUG_FSC, "inode %p get aux %u", &v9inode->vfs_inode,

		   v9inode->fscache_key->version);

	return sizeof(v9inode->fscache_key->version);

		   v9inode->qid.version);

	return sizeof(v9inode->qid.version);

}



static enum
@@ -143,11 +141,11 @@ fscache_checkaux v9fs_cache_inode_check_aux(void *cookie_netfs_data, 
{

	const struct v9fs_inode *v9inode = cookie_netfs_data;



	if (buflen != sizeof(v9inode->fscache_key->version))

	if (buflen != sizeof(v9inode->qid.version))

		return FSCACHE_CHECKAUX_OBSOLETE;



	if (memcmp(buffer, &v9inode->fscache_key->version,

		   sizeof(v9inode->fscache_key->version)))

	if (memcmp(buffer, &v9inode->qid.version,

		   sizeof(v9inode->qid.version)))

		return FSCACHE_CHECKAUX_OBSOLETE;



	return FSCACHE_CHECKAUX_OKAY;

fs/9p/cache.h

+0 −9
Original line number Diff line number Diff line
@@ -93,15 +93,6 @@ static inline void v9fs_uncache_page(struct inode *inode, struct page *page) 
	BUG_ON(PageFsCache(page));

}



static inline void v9fs_fscache_set_key(struct inode *inode,

					struct p9_qid *qid)

{

	struct v9fs_inode *v9inode = V9FS_I(inode);

	spin_lock(&v9inode->fscache_lock);

	v9inode->fscache_key = qid;

	spin_unlock(&v9inode->fscache_lock);

}



static inline void v9fs_fscache_wait_on_page_write(struct inode *inode,

						   struct page *page)

{

fs/9p/v9fs.c

+1 −1
Original line number Diff line number Diff line
@@ -487,8 +487,8 @@ static void v9fs_inode_init_once(void *foo) 
	struct v9fs_inode *v9inode = (struct v9fs_inode *)foo;

#ifdef CONFIG_9P_FSCACHE

	v9inode->fscache = NULL;

	v9inode->fscache_key = NULL;

#endif

	memset(&v9inode->qid, 0, sizeof(v9inode->qid));

	inode_init_once(&v9inode->vfs_inode);

}

fs/9p/v9fs.h

+1 −1
Original line number Diff line number Diff line
@@ -125,8 +125,8 @@ struct v9fs_inode { 
#ifdef CONFIG_9P_FSCACHE

	spinlock_t fscache_lock;

	struct fscache_cookie *fscache;

	struct p9_qid *fscache_key;

#endif

	struct p9_qid qid;

	unsigned int cache_validity;

	struct p9_fid *writeback_fid;

	struct mutex v_mutex;

fs/9p/vfs_inode.c

+33 −3
Original line number Diff line number Diff line
@@ -216,7 +216,6 @@ struct inode *v9fs_alloc_inode(struct super_block *sb) 
		return NULL;

#ifdef CONFIG_9P_FSCACHE

	v9inode->fscache = NULL;

	v9inode->fscache_key = NULL;

	spin_lock_init(&v9inode->fscache_lock);

#endif

	v9inode->writeback_fid = NULL;
@@ -433,6 +432,37 @@ void v9fs_evict_inode(struct inode *inode) 
	}

}



static int v9fs_test_inode(struct inode *inode, void *data)

{

	int umode;

	struct v9fs_inode *v9inode = V9FS_I(inode);

	struct p9_wstat *st = (struct p9_wstat *)data;

	struct v9fs_session_info *v9ses = v9fs_inode2v9ses(inode);



	umode = p9mode2unixmode(v9ses, st->mode);

	/* don't match inode of different type */

	if ((inode->i_mode & S_IFMT) != (umode & S_IFMT))

		return 0;



	/* compare qid details */

	if (memcmp(&v9inode->qid.version,

		   &st->qid.version, sizeof(v9inode->qid.version)))

		return 0;



	if (v9inode->qid.type != st->qid.type)

		return 0;

	return 1;

}



static int v9fs_set_inode(struct inode *inode,  void *data)

{

	struct v9fs_inode *v9inode = V9FS_I(inode);

	struct p9_wstat *st = (struct p9_wstat *)data;



	memcpy(&v9inode->qid, &st->qid, sizeof(st->qid));

	return 0;

}



static struct inode *v9fs_qid_iget(struct super_block *sb,

				   struct p9_qid *qid,

				   struct p9_wstat *st)
@@ -443,7 +473,7 @@ static struct inode *v9fs_qid_iget(struct super_block *sb, 
	struct v9fs_session_info *v9ses = sb->s_fs_info;



	i_ino = v9fs_qid2ino(qid);

	inode = iget_locked(sb, i_ino);

	inode = iget5_locked(sb, i_ino, v9fs_test_inode, v9fs_set_inode, st);

	if (!inode)

		return ERR_PTR(-ENOMEM);

	if (!(inode->i_state & I_NEW))
@@ -453,6 +483,7 @@ static struct inode *v9fs_qid_iget(struct super_block *sb, 
	 * FIXME!! we may need support for stale inodes

	 * later.

	 */

	inode->i_ino = i_ino;

	umode = p9mode2unixmode(v9ses, st->mode);

	retval = v9fs_init_inode(v9ses, inode, umode);

	if (retval)
@@ -460,7 +491,6 @@ static struct inode *v9fs_qid_iget(struct super_block *sb, 


	v9fs_stat2inode(st, inode, sb);

#ifdef CONFIG_9P_FSCACHE

	v9fs_fscache_set_key(inode, &st->qid);

	v9fs_cache_inode_get_cookie(inode);

#endif

	unlock_new_inode(inode);

CRA Git | Maintained and supported by SUSTech CRA and CCSE