net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe() (85496a29) · Commits · 戴 / test

Fix the missing clk_disable_unprepare() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Wang Hai <wanghai38@huawei.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/cortina/gemini.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2446,6 +2446,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
		port->reset = devm_reset_control_get_exclusive(dev, NULL);
		if (IS_ERR(port->reset)) {
		dev_err(dev, "no reset\n");
		clk_disable_unprepare(port->pclk);
		return PTR_ERR(port->reset);
		}
		reset_control_reset(port->reset);
		@@ -2501,8 +2502,10 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
		IRQF_SHARED,
		port_names[port->id],
		port);
		if (ret)
		if (ret) {
		clk_disable_unprepare(port->pclk);
		return ret;
		}

		ret = register_netdev(netdev);
		if (!ret) {

Admin message