Commit 59929fbb authored Jul 29, 2020 by Shannon Nelson Committed by David S. Miller Jul 30, 2020

ionic: unlock queue mutex in error path



On an error return, jump to the unlock at the end to be sure
to unlock the queue_lock mutex.

Fixes: 0925e9db ("ionic: use mutex to protect queue operations")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 51875dad

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2001,7 +2001,7 @@ int ionic_reset_queues(struct ionic_lif lif, ionic_reset_cb cb, void arg)
		netif_device_detach(lif->netdev);
		err = ionic_stop(lif->netdev);
		if (err)
		return err;
		goto reset_out;
		}

		if (cb)
		@@ -2011,6 +2011,8 @@ int ionic_reset_queues(struct ionic_lif lif, ionic_reset_cb cb, void arg)
		err = ionic_open(lif->netdev);
		netif_device_attach(lif->netdev);
		}

		reset_out:
		mutex_unlock(&lif->queue_lock);

		return err;

Admin message