Commit 826f7e34 authored Dec 17, 2019 by Brian Foster Committed by Darrick J. Wong Dec 19, 2019

xfs: use bitops interface for buf log item AIL flag check



The xfs_log_item flags were converted to atomic bitops as of commit
22525c17 ("xfs: log item flags are racy"). The assert check for
AIL presence in xfs_buf_item_relse() still uses the old value based
check. This likely went unnoticed as XFS_LI_IN_AIL evaluates to 0
and causes the assert to unconditionally pass. Fix up the check.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Fixes: 22525c17 ("xfs: log item flags are racy")
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent b1de6fc7

fs/xfs/xfs_buf_item.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -956,7 +956,7 @@ xfs_buf_item_relse(
		struct xfs_buf_log_item *bip = bp->b_log_item;

		trace_xfs_buf_item_relse(bp, _RET_IP_);
		ASSERT(!(bip->bli_item.li_flags & XFS_LI_IN_AIL));
		ASSERT(!test_bit(XFS_LI_IN_AIL, &bip->bli_item.li_flags));

		bp->b_log_item = NULL;
		if (list_empty(&bp->b_li_list))

Admin message