Commit 805fa88e authored by Matthew Garrett's avatar Matthew Garrett Committed by Jarkko Sakkinen
Browse files

tpm: Don't make log failures fatal 



If a TPM is in disabled state, it's reasonable for it to have an empty
log. Bailing out of probe in this case means that the PPI interface
isn't available, so there's no way to then enable the TPM from the OS.
In general it seems reasonable to ignore log errors - they shouldn't
interfere with any other TPM functionality.

Signed-off-by: default avatarMatthew Garrett <matthewgarrett@google.com>
Cc: stable@vger.kernel.org # 4.19.x
Reviewed-by: default avatarJerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
parent 0d81a3f2

drivers/char/tpm/eventlog/common.c

+4 −8
Original line number Diff line number Diff line
@@ -99,11 +99,8 @@ static int tpm_read_log(struct tpm_chip *chip) 
 *

 * If an event log is found then the securityfs files are setup to

 * export it to userspace, otherwise nothing is done.

 *

 * Returns -ENODEV if the firmware has no event log or securityfs is not

 * supported.

 */

int tpm_bios_log_setup(struct tpm_chip *chip)

void tpm_bios_log_setup(struct tpm_chip *chip)

{

	const char *name = dev_name(&chip->dev);

	unsigned int cnt;
@@ -112,7 +109,7 @@ int tpm_bios_log_setup(struct tpm_chip *chip) 


	rc = tpm_read_log(chip);

	if (rc < 0)

		return rc;

		return;

	log_version = rc;



	cnt = 0;
@@ -158,13 +155,12 @@ int tpm_bios_log_setup(struct tpm_chip *chip) 
		cnt++;

	}



	return 0;

	return;



err:

	rc = PTR_ERR(chip->bios_dir[cnt]);

	chip->bios_dir[cnt] = NULL;

	tpm_bios_log_teardown(chip);

	return rc;

	return;

}



void tpm_bios_log_teardown(struct tpm_chip *chip)

drivers/char/tpm/tpm-chip.c

+1 −3
Original line number Diff line number Diff line
@@ -596,9 +596,7 @@ int tpm_chip_register(struct tpm_chip *chip) 


	tpm_sysfs_add_device(chip);



	rc = tpm_bios_log_setup(chip);

	if (rc != 0 && rc != -ENODEV)

		return rc;

	tpm_bios_log_setup(chip);



	tpm_add_ppi(chip);

drivers/char/tpm/tpm.h

+1 −1
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ int tpm2_prepare_space(struct tpm_chip *chip, struct tpm_space *space, u8 *cmd, 
int tpm2_commit_space(struct tpm_chip *chip, struct tpm_space *space, void *buf,

		      size_t *bufsiz);



int tpm_bios_log_setup(struct tpm_chip *chip);

void tpm_bios_log_setup(struct tpm_chip *chip);

void tpm_bios_log_teardown(struct tpm_chip *chip);

int tpm_dev_common_init(void);

void tpm_dev_common_exit(void);

CRA Git | Maintained and supported by SUSTech CRA and CCSE