Commit 7e731bc9 authored Aug 05, 2012 by Theodore Ts'o

ext4: avoid kmemcheck complaint from reading uninitialized memory

Commit 03179fe9 introduced a kmemcheck complaint in
ext4_da_get_block_prep() because we save and restore
ei->i_da_metadata_calc_last_lblock even though it is left
uninitialized in the case where i_da_metadata_calc_len is zero.

This doesn't hurt anything, but silencing the kmemcheck complaint
makes it easier for people to find real bugs.

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=45631


(which is marked as a regression).

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org

parent d796c52e

fs/ext4/super.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -959,6 +959,7 @@ static struct inode ext4_alloc_inode(struct super_block sb)
		ei->i_reserved_meta_blocks = 0;
		ei->i_allocated_meta_blocks = 0;
		ei->i_da_metadata_calc_len = 0;
		ei->i_da_metadata_calc_last_lblock = 0;
		spin_lock_init(&(ei->i_block_reservation_lock));
		#ifdef CONFIG_QUOTA
		ei->i_reserved_quota = 0;

Admin message